-
Notifications
You must be signed in to change notification settings - Fork 57
[TECH] Utilise les paliers acquis pour afficher les statistiques sur la page d'analyse (PIX-17297) #11996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
La-toile-cosmique
wants to merge
8
commits into
dev
Choose a base branch
from
pix-17297-compute-reached-level-from-stage-acquisitions
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[TECH] Utilise les paliers acquis pour afficher les statistiques sur la page d'analyse (PIX-17297) #11996
La-toile-cosmique
wants to merge
8
commits into
dev
from
pix-17297-compute-reached-level-from-stage-acquisitions
+297
−329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ignParticipationRepository
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
xav-car
reviewed
Apr 14, 2025
Comment on lines
150
to
+155
if (filters.badges || filters.unacquiredBadges) { | ||
orderByClauses.unshift({ column: 'campaign-participations.id' }); | ||
} | ||
if (filters.stages) { | ||
orderByClauses.unshift({ column: 'campaign-participations.id' }); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion :
filters.badges || filters.unacquiredBadges || filters.stages
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌸 Problème
Actuellement on calcule l'obtention des paliers a la volée pour afficher les statistiques sur la page d'analyse d'une campagne. Or grâce au travail entrepris par la défunte équipe @1024pix/team-evaluation 💞 l'acquisition des paliers est désormais stockée en base.
🌳 Proposition
Utiliser les acquisitions en base pour afficher et calculer les statistiques liées au paliers dans la page d'analyse.
🐝 Remarques
J'ai utilisé le usecase d'acquisition dans les seeds pour obtenir des données cohérentes 🤷🏼.
🤧 Pour tester
Se rendre sur la page d'analyse d'une campagne.
Attester de la cohérence des données 🕵🏼 .