[TECH] Renommer et regrouper les routes et controlleurs d'attestation pour évoquer un certificat (Pix-17439) #12015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaf
added
👀 Tech Review Needed
👀 Func Review Needed
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
yaf
force-pushed
the
pix-17439-rename-certificat-and-merge-route-and-controller
branch
4 times, most recently
from
168b2c4 to
629dd79
Compare
yaf
added
👀 Func Review Needed
| @@ -16,20 +49,20 @@ const getPDFAttestation = async function ( | |||
| const { i18n } = request; | |||
| const { isFrenchDomainExtension } = request.query; | |||
|
|
|||
| const attestation = await usecases.getCertificationAttestation({ | |||
| const certificate = await usecases.getCertificationAttestation({ | |||
There was a problem hiding this comment.
Le renommage des usecases aura lieu dans une autre PR ?
There was a problem hiding this comment.
Oui, je pense que c'est mieux. Je fais par petites étapes
alexandrecoin
approved these changes
Apr 11, 2025
alexandrecoin
added
Func Review OK
yaf
force-pushed
the
pix-17439-rename-certificat-and-merge-route-and-controller
branch
from
629dd79 to
7b8e630
Compare
Jeyffrey
reviewed
Apr 11, 2025
| @@ -261,20 +443,16 @@ describe('Certification | Results | Unit | Application | Controller | certificat | |||
| division, | |||
| organizationId, | |||
| }) | |||
| .resolves([v3CertificationAttestation, v3CertificationAttestation, v2CertificationAttestation]); | |||
| .resolves([v3CertificationAttestation, v3CertificationAttestation]); | |||
There was a problem hiding this comment.
ça rollback ma correction d'ici #12013
There was a problem hiding this comment.
C'est sans doute un raté sur un rebase. Je vais reprendre ça
There was a problem hiding this comment.
Bon, je pense que c'est une histoire de date de commit, et les miens ont du passé par-dessus le tien. Je viens de faire un cherry-pick pour « re-appliquer » tes modifications.
yaf
force-pushed
the
pix-17439-rename-certificat-and-merge-route-and-controller
branch
from
7b8e630 to
6aa589f
Compare
pix-service-auto-merge
force-pushed
the
pix-17439-rename-certificat-and-merge-route-and-controller
branch
2 times, most recently
from
3a043ae to
ae1c265
Compare
pix-service-auto-merge
force-pushed
the
pix-17439-rename-certificat-and-merge-route-and-controller
branch
from
ae1c265 to
7bd3a31
Compare
pix-service-auto-merge
deleted the
pix-17439-rename-certificat-and-merge-route-and-controller
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌸 Problème
🌳 Proposition
🐝 Remarques
Les URL n'ont pas été modifiés pour le moment.
🤧 Pour tester
Faire le parcours pour récupérer un certificat / attestation, tout devrait fonctionner comme avant.