[BUGFIX] Rajouter les labels sur la nav de Pix admin (PIX-17448) #12019
+15
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌸 Problème
Le composant PixNavigation possède désormais 2 attributs en plus (openLabel et closeLabel) qui sont affichés uniquement pour les lecteurs d'écrans. Ils ne sont pas présent sur Pix admin.
🌳 Proposition
Rajouter les labels en les traduisants au passage.
🐝 Remarques
On rajoute également l'attributs navigationAriaLabel qui n'était pas présent.
🤧 Pour tester
scalingo -a pix-api-review-pr12019 run npm run toggles -- --key isPixAdminNewSidebarEnabled --value true