remove MirrorSparseMatrix; delete enclone_visual #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macklin-10x
requested review from
sjackman,
sreenathkrishnan,
shamoni and
nmmsv10x
macklin-10x
force-pushed
the
macklin/remove-custom-sparse-matrix
branch
from
0659617 to
73aa8d1
Compare
sreenathkrishnan
approved these changes
Mar 6, 2024
| <p><b>5/9/22</b>: Add ability to create <span style="color:rgb(120,123,175);font-weight:900">enclone visual</span> sessions from the command line. Please | ||
| see <a href="../../pages/auto/visual.html"><span style="color:rgb(120,123,175);font-weight:900">enclone visual</span></a>.</p> | ||
| <p><b>5/9/22</b>: Add ability to create <span style="color:rgb(120,123,175);font-weight:900">enclone</span>_visual sessions from the command line. Please | ||
| see <a href="../../pages/auto/visual.html"><span style="color:rgb(120,123,175);font-weight:900">enclone</span>_visual</a>.</p> |
There was a problem hiding this comment.
should we remove these lines. Not sure why _visual is pushed outside the span
There was a problem hiding this comment.
Since this is revision history I figured we should leave it alone.
| @@ -78,7 +78,6 @@ <h2><span style="color:rgb(120,123,175);font-weight:900">enclone</span> changes | |||
| <thead> | |||
| <tr> | |||
| <th align="left"> date </th> | |||
| <th align="left"> enclone version </th> | |||
There was a problem hiding this comment.
Was this intentional?
There was a problem hiding this comment.
Hmm, that's a good question. I'm honestly not sure. Somewhere in here I think I ran a command to re-generate the generated HTML.
There was a problem hiding this comment.
Yeah I'm pretty sure this file was actually just stale and by re-generating the html docs this was actually fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes everything that depended on the known-dead MirrorSparseMatrix type removed in 10XGenomics/enclone_ranger#384
Deletes
enclone_visualand everything I could find relating to it.