Ложное срабатывание doc-comment-description-ends-on-dot для секции #1493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Добавить сценарий в тестовый кейс * Количество маркеров и их положение не изменяется
MaksimDzyuba
approved these changes
May 14, 2025
vadimeg
approved these changes
May 19, 2025
| private boolean isParentExampleSection(BslDocumentationComment root, TextPart lastPart) | ||
| { | ||
| return root.getExampleSection() != null | ||
| && root.getExampleSection().getDescription().getParts().contains(lastPart); |
There was a problem hiding this comment.
А getDescription() или getParts() не могут null вернуть?
Я контракт не смотрел, просто уточняю, не нужно ли тут проверить на null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что сделано
Чек-лист
Общее:
masterи нет конфликтовЕсли применимо:
Закрываемые задачи
Closes #??