You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the course of refactoring the JS SDK as above, there has been a point where, although all NPM linting commands were succeeding, the examples commonjs and es were not, because of misconfigured exports.
Desired Behavior
We should make sure that within the test suite, there are end-to-end tests to avoid regressions.
Benefits & Value
We would no longer rely on manual testing to detect misconfigurations such as in #15 and will be able to more confidently add such refactors.
Current Behavior
#15
In the course of refactoring the JS SDK as above, there has been a point where, although all NPM linting commands were succeeding, the examples
commonjs
andes
were not, because of misconfigured exports.Desired Behavior
We should make sure that within the test suite, there are end-to-end tests to avoid regressions.
Benefits & Value
We would no longer rely on manual testing to detect misconfigurations such as in #15 and will be able to more confidently add such refactors.
Additional information
There has been a prior attempt to do this here:
https://github.com/1Password/onepassword-sdk-js/pull/22/files
However, this should only be used as inspiration as it is not finalized.
The text was updated successfully, but these errors were encountered: