Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test JS SDK exports and packaging #42

Open
hculea opened this issue May 21, 2024 · 0 comments
Open

Test JS SDK exports and packaging #42

hculea opened this issue May 21, 2024 · 0 comments

Comments

@hculea
Copy link
Member

hculea commented May 21, 2024

Current Behavior

#15

In the course of refactoring the JS SDK as above, there has been a point where, although all NPM linting commands were succeeding, the examples commonjs and es were not, because of misconfigured exports.

Desired Behavior

We should make sure that within the test suite, there are end-to-end tests to avoid regressions.

Benefits & Value

We would no longer rely on manual testing to detect misconfigurations such as in #15 and will be able to more confidently add such refactors.

Additional information

There has been a prior attempt to do this here:

https://github.com/1Password/onepassword-sdk-js/pull/22/files

However, this should only be used as inspiration as it is not finalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant