Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.4.0 #416

Merged
merged 168 commits into from
Aug 8, 2024
Merged

Release v3.4.0 #416

merged 168 commits into from
Aug 8, 2024

Conversation

steven-murray
Copy link
Member

v3.4.0

Performance

  • When reading in data from cache, only read the necessary fields.

Deprecations

  • Python <3.9 is no longer supported.

Fixed

  • Fixed small issue in Lightcone.lightcone_coords.
  • Bug when setting NON_CUBIC_FACTOR != 1.
  • Using new matplotlib versions and registering cmap.
  • Small bug in lightcone interpolation.

Added

  • New Lightconer base class with user-facing classes RectilinearLightconer and
    AngularLightconer. These are now the recommended way to define how lightcones
    should be created. Note that these are not the final lightcone object, but simply a
    "definition" for how to create the lightcone.
  • The Lightcone class still exists, but is now joined by an AngularLightcone
    class that is the output lightcone when using the AngularLightconer definition.
  • New KEEP_3D_VELOCITIES user-param. This is required to be True if you want to
    apply RSDs to an AngularLightcone.
  • Ability to check-point lightcone creation, so that it can be resumed later. Simply
    pass the lightcone_fname argument to run_lightcone.
  • New cache_tools.get_boxes_at_redshift function to get all boxes at a given
    redshift, regardless of the parameters used to create them.
  • New CosmoParams.from_astropy() classmethod for constructing a cosmo params object
    directly from an astropy cosmology.

Internals

  • Refactored RSDs to the subcell_rsds.c C-module.
  • Added CI testing of the docs tutorials.
  • More precise debugging summaries of boxes in the C code.

Fixed

  • Incorrect sign on adiabatic fluctuations.
  • Spurious warnings about boxes being read.
  • Spurious warnings about configuration files being out of date.
  • Compilation for clang and newer gcc versions.

steven-murray and others added 30 commits November 18, 2022 12:13
@steven-murray steven-murray requested a review from daviesje August 7, 2024 11:01
@steven-murray steven-murray self-assigned this Aug 7, 2024
@steven-murray steven-murray changed the base branch from master to production August 7, 2024 11:02
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 88.60104% with 66 lines in your changes missing coverage. Please review.

Project coverage is 82.19%. Comparing base (f75560c) to head (3dc9953).
Report is 373 commits behind head on production.

Files with missing lines Patch % Lines
src/py21cmfast/outputs.py 79.34% 13 Missing and 6 partials ⚠️
src/py21cmfast/_utils.py 56.00% 9 Missing and 2 partials ⚠️
src/py21cmfast/lightcones.py 95.76% 4 Missing and 4 partials ⚠️
src/py21cmfast/wrapper.py 93.75% 2 Missing and 6 partials ⚠️
src/py21cmfast/_cfg.py 30.00% 4 Missing and 3 partials ⚠️
src/py21cmfast/cli.py 76.66% 4 Missing and 3 partials ⚠️
src/py21cmfast/cache_tools.py 82.85% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           production     #416      +/-   ##
==============================================
- Coverage       86.33%   82.19%   -4.14%     
==============================================
  Files              12       13       +1     
  Lines            2780     3140     +360     
  Branches            0      854     +854     
==============================================
+ Hits             2400     2581     +181     
- Misses            380      400      +20     
- Partials            0      159     +159     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@daviesje daviesje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@steven-murray steven-murray merged commit e6d3135 into production Aug 8, 2024
20 of 21 checks passed
@steven-murray steven-murray deleted the release branch August 8, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants