Added documentation on xvfb

3arthqu4ke · Nov 13, 2024 · 7acb022 · 7acb022
1 parent 2bfdfc6
commit 7acb022
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/...src/main/java/me/earth/headlessmc/launcher/instrumentation/xvfb/XvfbLwjglTransformer.java b/...src/main/java/me/earth/headlessmc/launcher/instrumentation/xvfb/XvfbLwjglTransformer.java
@@ -9,6 +9,11 @@
 
 import java.util.Locale;
 
+/**
+ * Lwjgl 2.9.4 (Mc 1.12.2) crashes in Github actions with xvfb at getAvailableDisplayModes,
+ * because the array returned by XRandR.getResolutions is empty.
+ * This patches that by always using XF86VIDMODE instead of XRANDR.
+ */
 @CustomLog
 public class XvfbLwjglTransformer extends AbstractClassTransformer {
     public XvfbLwjglTransformer() {
@@ -17,6 +22,8 @@ public XvfbLwjglTransformer() {
 
     @Override
     protected void transform(ClassNode cn) {
+        // TODO: Actually isXrandrSupported can also be overriden by setting the system property LWJGL_DISABLE_XRANDR
+        // but this would theoretically cover the case when XF86VIDMODE is not supported?
         for (MethodNode mn : cn.methods) {
             if ("getBestDisplayModeExtension".equals(mn.name) && "()I".equals(mn.desc)) {
                 for (AbstractInsnNode insnNode : mn.instructions) {