Fallback to use API for getting channel data when not in the cache #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Pushed a fix which also fixes this: Likely due to the same issue where page limit isn't obeyed so not present in the cache. This is not really a fix but more a workaround. Untested, will do more testing tomorrow (it's late here). |
hloeung
changed the title
|
#491, I think we should still have this as a fallback, but your call. |
|
Yes a fallback is a good idea, will add this after matterbridge/matterclient#1 merges |
|
Can you rebase on master? vendor has been updated |
|
Sure, working on that now. Apologies for the mess with the various PRs. Will be more careful and neater next time. |
|
Ok, done. Also pushed up a drive-by fix from #491 |
No apologies needed though :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #479