Skip to content

Don't run pkg.pr.new if there aren't changes to the nuqs package #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
franky47 opened this issue Sep 26, 2024 · 2 comments · Fixed by #656
Closed

Don't run pkg.pr.new if there aren't changes to the nuqs package #655

franky47 opened this issue Sep 26, 2024 · 2 comments · Fixed by #656
Labels
github_actions Pull requests that update Github_actions code good first issue Good for newcomers hacktoberfest released

Comments

@franky47
Copy link
Member

franky47 commented Sep 26, 2024 •
edited
Loading

pkg.pr.new is a service by StackBlitz to deploy previews of NPM packages without polluting the NPM registry (it's pretty cool).

At the moment the PR preview workflow (pkg.pr.new.yml) runs on any PR.

This is kind of wasteful on pkg.pr.new's servers and resources: we should abort if the PR introduces no changes to what's actually being deployed.

PRs welcome!
@franky47 franky47 added good first issue Good for newcomers github_actions Pull requests that update Github_actions code hacktoberfest labels Sep 26, 2024
@chbg
Copy link
Contributor

chbg commented Sep 27, 2024

Hi, @franky47 ! I’ve submitted a pull request that addresses this issue by adding a conditional check to pkg.pr.new.yml to prevent unnecessary runs when there are no changes to the nuqs package. You can view the PR here. Looking forward to your feedback!

@franky47 franky47 linked a pull request Sep 27, 2024 that will close this issue
Fix: Run pkg.pr.new only if there are changes #656
Merged
@franky47 franky47 mentioned this issue Sep 27, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

🎉 This issue has been resolved in version 1.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code good first issue Good for newcomers hacktoberfest released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Run pkg.pr.new only if there are changes
2 participants
@franky47 @chbg