clean code

Author: 6bee

src/Remote.Linq/ExpressionTranslationExtensions.RemoteToSystemLinqTranslator.cs

@@ -161,7 +161,7 @@ private SystemLinq.NewExpression VisitNew(RemoteLinq.NewExpression node)
                 ?? throw new RemoteLinqException($"Failed to resolve constructor of node {nameof(RemoteLinq.NewExpression)}");
             if (node.Arguments is null)
             {
-                if (node.Members?.Any() ?? false)
+                if (node.Members?.Count > 0)
                 {
                     var members = node.Members.Select(x => x.ResolveMemberInfo(_typeResolver)).ToArray();
                     return SystemLinq.Expression.New(constructor, Array.Empty<SystemLinq.Expression>(), members);
@@ -176,7 +176,7 @@ private SystemLinq.NewExpression VisitNew(RemoteLinq.NewExpression node)
                 var arguments =
                     from a in node.Arguments
                     select Visit(a);
-                if (node.Members?.Any() ?? false)
+                if (node.Members?.Count > 0)
                 {
                     var members = node.Members.Select(x => x.ResolveMemberInfo(_typeResolver)).ToArray();
                     return SystemLinq.Expression.New(constructor, arguments, members);

src/Remote.Linq/Expressions/InvokeExpression.cs

@@ -18,7 +18,7 @@ public InvokeExpression()
     public InvokeExpression(Expression expression, IEnumerable<Expression>? arguments)
     {
         Expression = expression.CheckNotNull();
-        Arguments = arguments?.Any() ?? false ? arguments.ToList() : null;
+        Arguments = arguments?.Any() is true ? arguments.ToList() : null;
     }
 
     public override ExpressionType NodeType => ExpressionType.Invoke;

src/Remote.Linq/SimpleQuery/Query.cs

@@ -112,7 +112,7 @@ public IOrderedQuery OrderByDescending(SortExpression sortExpression)
     /// <returns>A new query instance containing all specified query parameters.</returns>
     IOrderedQuery IOrderedQuery.ThenBy(SortExpression sortExpression)
     {
-        if (SortExpressions?.Any() is not true)
+        if (SortExpressions?.Count is null or 0)
         {
             throw new InvalidOperationException("No sorting defined yet, use OrderBy or OrderByDescending first.");
         }
@@ -136,7 +136,7 @@ IOrderedQuery IOrderedQuery.ThenBy(SortExpression sortExpression)
     /// <returns>A new query instance containing all specified query parameters.</returns>
     IOrderedQuery IOrderedQuery.ThenByDescending(SortExpression sortExpression)
     {
-        if (SortExpressions?.Any() is not true)
+        if (SortExpressions?.Count is null or 0)
         {
             throw new InvalidOperationException("No sorting defined yet, use OrderBy or OrderByDescending first.");
         }

src/Remote.Linq/SimpleQuery/Query`1.cs

@@ -117,8 +117,8 @@ public IOrderedQuery<T> OrderByDescending<TKey>(Expression<Func<T, TKey>> keySel
     /// <returns>A new query instance containing all specified query parameters.</returns>
     IOrderedQuery<T> IOrderedQuery<T>.ThenBy<TKey>(Expression<Func<T, TKey>> keySelector)
     {
-        var sortExpressions = SortExpressions.AsEmptyIfNull().ToList();
-        if (!sortExpressions.Any())
+        var sortExpressions = SortExpressions?.ToList();
+        if (sortExpressions?.Count is null or 0)
         {
             throw new InvalidOperationException($"No sorting defined yet, use {nameof(OrderBy)} or {nameof(OrderByDescending)} first.");
         }
@@ -140,8 +140,8 @@ IOrderedQuery<T> IOrderedQuery<T>.ThenBy<TKey>(Expression<Func<T, TKey>> keySele
     /// <returns>A new query instance containing all specified query parameters.</returns>
     IOrderedQuery<T> IOrderedQuery<T>.ThenByDescending<TKey>(Expression<Func<T, TKey>> keySelector)
     {
-        var sortExpressions = SortExpressions.AsEmptyIfNull().ToList();
-        if (!sortExpressions.Any())
+        var sortExpressions = SortExpressions?.ToList();
+        if (sortExpressions?.Count is null or 0)
         {
             throw new InvalidOperationException("No sorting defined yet, use OrderBy or OrderByDescending first.");
         }

test/Remote.Linq.Tests/AsyncQueryableExtensions/Ensure_async_method_provided_for_every_synchronous_query_operation.cs

@@ -44,7 +44,7 @@ public void Method_should_have_async_counterpart(MethodInfo method)
             .ToArray();
         matchingMethods.ShouldNotBeEmpty($"No method found with name '{methodName}'");
 
-        if (genericArgumentTypes.Any())
+        if (genericArgumentTypes.Length > 0)
         {
             matchingMethods = matchingMethods
                 .Where(x => x.IsGenericMethodDefinition && x.GetGenericArguments().Length == genericArgumentTypes.Length)