Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errorless cleanup of un-initialized HDF5 files #115

Open
salotz opened this issue Oct 24, 2023 · 0 comments
Open

Errorless cleanup of un-initialized HDF5 files #115

salotz opened this issue Oct 24, 2023 · 0 comments
Assignees
@salotz
Labels
bug enhancement
Milestone
Proper 1.2 version

Comments

@salotz
Copy link
Collaborator

salotz commented Oct 24, 2023

As seen in the traceback of #112 if the HDF5Reporter is not initialized properly in a context manager you get a confusing AttributeError if there is no closed attribute.
This should be handled more cleanly by either ensuring a meaningful closed is always present or first checking if this attribute exists.
@salotz salotz added this to the Proper 1.2 version milestone Oct 24, 2023
@salotz salotz self-assigned this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salotz salotz

Labels
bug enhancement
Projects
None yet
Milestone
Proper 1.2 version
Development

No branches or pull requests
1 participant
@salotz