-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a getAvailableCollections method in python #536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections from my side to add this (and potentially deprecate the collections
property and removing it after the next tag. Unless, you want to keep that for the "pythonic interface"?
|
python/podio/frame.py
Outdated
print('WARNING: collections is deprecated, use getAvailableCollections() (like in C++) instead', | ||
file=sys.stderr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this a warnings.warn("text", FutureWarning)
? That would give a bit more context as to where the warning is coming from
BEGINRELEASENOTES
getAvailableCollections
method in python that does the same thing as in C++ENDRELEASENOTES
Currently
frame.collections
is the way of getting the collections. I'd prefer the C++ method and the python one to have the same name so it's easier to remember.I'm also in favor of removing the current
.collections
which is probably only used in podio (in podio-dump).