Remove the Frame from the default readers and writers
#549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
rename-root
branch
2 times, most recently
from
9b483c2 to
9ced502
Compare
tmadlener
force-pushed
the
rename-root
branch
from
de59b2a to
c196a99
Compare
clang-tidy seems to struggle with the "header-only" implementation otherwise and not be able to parse out necessary include directories from the compile_commands.json
This was referenced Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
{ROOT,SIO}Frame{Reader,Writer}to{ROOT,SIO}{Reader,Writer}since these names are now no longer taken by the deprecatedEventStorebased ones and Frame based I/O is the default now.ENDRELEASENOTES