Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for push_back when using an immutable type #577

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Improve error message for push_back when using an immutable type #577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/templates/Collection.cc.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ void {{ collection_type }}::push_back(Mutable{{ class.bare_type }} object) {

void {{ collection_type }}::push_back({{ class.bare_type }} object) {
if (!m_isSubsetColl) {
throw std::invalid_argument("Can only add immutable objects to subset collections");
throw std::invalid_argument("Immutable objects can only be added to subset collections");
}
auto obj = object.m_obj;
if (obj->id.index < 0) {
Expand Down