Make the TTree based ROOT backend store the GenericParameters the same way as the RNTuple based one #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
changed the title
tmadlener
changed the title
tmadlener
force-pushed
the
uniform-generic-param-storage
branch
from
f88e3a1 to
a2b022b
Compare
tmadlener
force-pushed
the
uniform-generic-param-storage
branch
from
a2b022b to
40b7634
Compare
- Lift common type defs into one header to not redefine them - Keep all root related utilitie classes in one header
tmadlener
force-pushed
the
uniform-generic-param-storage
branch
from
771d995 to
7398cf3
Compare
hegner
approved these changes
Jun 11, 2024
| @@ -30,6 +31,10 @@ class RNTupleWriter; | |||
|
|
|||
| namespace podio { | |||
|
|
|||
| #if !defined(__CLING__) | |||
There was a problem hiding this comment.
one line of documentation why that is the case - if possible to explain
hegner
approved these changes
Jun 11, 2024
hegner
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseded by #625