update

Author: ALTaleX531

Common/Api.cpp

@@ -66,7 +66,7 @@ bool Api::IsCurrentProcessInBlockList()
 	// TranslucentFlyouts won't be loaded into one of these process
 	// These processes are quite annoying because TranslucentFlyouts will not be automatically unloaded by them
 	// Some of them even have no chance to show flyouts and other UI elements
-	const std::array blockList
+	static const std::array blockList
 	{
 		L"sihost.exe"sv,
 		L"WSHost.exe"sv,
@@ -128,8 +128,8 @@ bool Api::InteractiveIO::OutputToConsole(
 		return false;
 	}
 
-	static WCHAR str[32768 + 1]{};
-	LoadStringW(wil::GetModuleInstanceHandle(), strResourceId, str, 32768);
+	LPCWSTR buffer{ nullptr };
+	auto length{ LoadStringW(wil::GetModuleInstanceHandle(), strResourceId, reinterpret_cast<LPWSTR>(&buffer), 0)};
 
 	switch (strType)
 	{
@@ -152,7 +152,7 @@ bool Api::InteractiveIO::OutputToConsole(
 		break;
 	}
 
-	auto outputString{std::format(L"{}{}{}", prefixStr, str, additionalStr)};
+	auto outputString{std::format(L"{}{}{}", prefixStr, std::wstring_view{ buffer, static_cast<size_t>(length) }, additionalStr)};
 	std::wcout << outputString;
 #ifdef _DEBUG
 	OutputDebugStringW(outputString.c_str());
@@ -246,15 +246,20 @@ bool Api::IsPartDisabledExternally(std::wstring_view part)
 		(
 			GetSystemPowerStatus(&powerStatus) &&
 			powerStatus.SystemStatusFlag
-		)
-	) ||
-	RegHelper::Get<DWORD>({ L"DisabledList" }, Utils::get_process_name(), 0);
+		) ||
+		RegHelper::Get<DWORD>({ L"DisabledList" }, Utils::get_process_name(), 0)
+	);
 }
 
 bool Api::IsStartAllBackTakingOver(std::wstring_view part)
 {
 	if (GetModuleHandleW(L"StartAllBackX64.dll"))
 	{
+		if (!_wcsicmp(part.data(), L"DropDown"))
+		{
+			return false;
+		}
+
 		if (part.empty() || !_wcsicmp(part.data(), L"Menu"))
 		{
 			auto immersiveMenus{ wil::reg::try_get_value_dword(HKEY_CURRENT_USER, L"SOFTWARE\\StartIsBack", L"ImmersiveMenus") };

Common/RegHelper.hpp

@@ -14,23 +14,24 @@ namespace TranslucentFlyouts
 #endif // _WIN64
 
 		template <typename T, bool reverse>
-		inline std::optional<T> GetValueInternal(std::wstring_view root, std::vector<std::wstring_view> keyTree, std::wstring_view valueName, size_t maxFallThrough)
+		inline std::optional<T> GetValueInternal(std::wstring_view root, std::vector<std::wstring_view> keyTree, std::wstring_view valueName, size_t maxFallThrough) try
 		{
 			std::optional<T> value{};
 			std::wstring keyName{ root };
 			maxFallThrough += 1;
 
 			if (!keyTree.empty())
 			{
-				for (auto index{ 0 }; index < keyTree.size(); index++)
+				for (auto i{ 1ull }; i <= keyTree.size(); i++)
 				{
 					keyName = root;
-					for (auto i{ keyTree.size() - 1 }; i >= index && maxFallThrough > 0; i--, maxFallThrough--)
+					for (auto j{ 0ull }; j < i && maxFallThrough >= 0; j++, maxFallThrough--)
 					{
-						if (!keyTree[i].empty())
+						auto index{ keyTree.size() - j - 1 };
+						if (!keyTree[index].empty())
 						{
 							keyName += L"\\";
-							keyName += keyTree[i];
+							keyName += keyTree[index];
 						}
 					}
 
@@ -98,6 +99,8 @@ namespace TranslucentFlyouts
 
 			return value;
 		}
+		catch(...) { return std::nullopt; }
+
 		template <typename T, bool reverse>
 		inline HRESULT SetValueInternal(std::wstring_view root, std::vector<std::wstring_view> keyTree, std::wstring_view valueName, T value, size_t maxFallThrough)
 		{

Common/Utils.hpp

@@ -85,7 +85,7 @@ namespace TranslucentFlyouts::Utils
 		return std::wstring{filePath};
 	}
 
-	inline std::wstring get_process_name()
+	inline const std::wstring& get_process_name()
 	{
 		static const auto s_processName{ get_module_base_file_name(nullptr) };
 		return s_processName;
@@ -216,6 +216,36 @@ namespace TranslucentFlyouts::Utils
 		return classNameOK && windowTextOK;
 	}
 
+	inline bool IsCurrentThreadContainVisibleWindow()
+	{
+		bool contain{ false };
+		EnumThreadWindows(GetCurrentThreadId(), [](HWND hWnd, LPARAM lParam)
+		{
+			if (IsWindowVisible(hWnd))
+			{
+				*reinterpret_cast<bool*>(lParam) = true;
+				return FALSE;
+			}
+			return TRUE;
+		}, reinterpret_cast<LPARAM>(&contain));
+		return contain;
+	}
+
+	template <UINT id>
+	__forceinline const std::wstring_view GetResWStringView()
+	{
+		LPCWSTR buffer{ nullptr };
+		auto length{ LoadStringW(wil::GetModuleInstanceHandle(), id, reinterpret_cast<LPWSTR>(&buffer), 0)};
+		return { buffer, static_cast<size_t>(length) };
+	}
+	template <UINT id>
+	__forceinline std::wstring GetResWString()
+	{
+		LPCWSTR buffer{ nullptr };
+		auto length{ LoadStringW(wil::GetModuleInstanceHandle(), id, reinterpret_cast<LPWSTR>(&buffer), 0) };
+		return std::wstring{ buffer, static_cast<size_t>(length) };
+	}
+
 	static bool IsPopupMenu(HWND hWnd)
 	{
 		WCHAR pszClass[MAX_PATH + 1] {};