Skip to content

Commit

Permalink
remove an old abort on jacobian for simplified-SDC
Browse files Browse the repository at this point in the history
not only is it no longer true, it also did not work because
the extern runtime parameters were not initialized at this point
  • Loading branch information
zingale committed Jan 4, 2024
1 parent 705f279 commit ebf2d53
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
7 changes: 6 additions & 1 deletion .clang-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@ Checks: >
-cppcoreguidelines-no-malloc,
-cppcoreguidelines-non-private-member-variables-in-classes,
-cppcoreguidelines-owning-memory,
-cppcoreguidelines-pro-*,
-cppcoreguidelines-pro-bounds-pointer-arithmetic,
-cppcoreguidelines-pro-type-cstyle-cast,
-cppcoreguidelines-pro-bounds-array-to-pointer-decay,
-cppcoreguidelines-pro-bounds-constant-array-index,
modernize-*,
modernize-*,
-modernize-avoid-c-arrays,
-modernize-use-trailing-return-type,
Expand Down
7 changes: 0 additions & 7 deletions Source/driver/Castro.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -322,13 +322,6 @@ Castro::read_params ()
}
#endif

#ifdef REACTIONS
#ifdef SIMPLIFIED_SDC
if (jacobian == 1) {
amrex::Abort("Simplified SDC requires the numerical Jacobian now (jacobian = 2)");
}
#endif
#endif
// sanity checks

if (grown_factor < 1) {
Expand Down

0 comments on commit ebf2d53

Please sign in to comment.