Skip to content

Commit

Permalink
more tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
zingale committed Feb 11, 2025
1 parent 45d2138 commit 635669c
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 10 deletions.
6 changes: 2 additions & 4 deletions Docs/source/eos_cell.rst
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,8 @@ The parameters that affect the thermodynamics are:

* ``unit_test.temperature`` : the initial temperature

The composition can be set in the same way as in ``burn_cell``, either
by setting each mass fraction explicitly via the parameters,
``unit_test.X1``, ``unit_test.X2``, ..., or forcing them to be all
equal via ``unit_test.uniform_xn=1``.
The composition can be set either by specifying individual mass fractions
or setting ``unit_test.uniform_xn`` as described in :ref:`sec:defining_unit_test_composition`.


Building and Running the Code
Expand Down
13 changes: 9 additions & 4 deletions Docs/source/jac_cell.rst
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,15 @@ The parameters that affect the thermodynamics are:

* ``unit_test.temperature`` : the initial temperature

While the mass fractions can be set individually (using
``unit_test.X1``, ``unit_test.X2``, ...), it is recommended to use
``unit_test.uniform_xn=1`` to initialize all the mass fractions to be
equal.
The composition can be set either by specifying individual mass fractions
or setting ``unit_test.uniform_xn`` as described in :ref:`sec:defining_unit_test_composition`.

If the values don't sum to ``1`` initially, then the test will do a
normalization. This normalization can be disabled by setting:

::

unit_test.skip_initial_normalization = 1


Building and Running the Code
Expand Down
2 changes: 1 addition & 1 deletion Docs/source/unit_test_runtime_parameters.rst
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Most of the unit tests require a composition to be defined (for the
initial mass-fractions, $X_k$). There are a few ways this can be done
(depending on the test).

* One-zone (`*_cell`) tests usually do one of:
* One-zone (``*_cell``) tests usually do one of:

* *Explicitly setting the individual mass fractions.* This is
controlled by the parameters ``unit_test.X1``, ``unit_test.X2``, ..., ``unit_test.X35``,
Expand Down
2 changes: 1 addition & 1 deletion unit_test/test_sdc_vode_rhs/vode_rhs_test.H
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ void do_vode_rhs()

for (int n = 1; n <= NumSpec; ++n) {

massfractions[n-1] = get_xn(n);
massfractions[n-1] = get_xn(n, unit_test_rp::uniform_xn);

if (massfractions[n-1] < 0 || massfractions[n-1] > 1) {
amrex::Error("mass fraction for " + short_spec_names_cxx[n-1] + " not initialized in the interval [0,1]!");
Expand Down

0 comments on commit 635669c

Please sign in to comment.