From 635669c8128426e2c6ae9c29f95ee800980f1609 Mon Sep 17 00:00:00 2001 From: Michael Zingale Date: Tue, 11 Feb 2025 15:01:44 -0500 Subject: [PATCH] more tweaks --- Docs/source/eos_cell.rst | 6 ++---- Docs/source/jac_cell.rst | 13 +++++++++---- Docs/source/unit_test_runtime_parameters.rst | 2 +- unit_test/test_sdc_vode_rhs/vode_rhs_test.H | 2 +- 4 files changed, 13 insertions(+), 10 deletions(-) diff --git a/Docs/source/eos_cell.rst b/Docs/source/eos_cell.rst index 5c19aa134c..c1a1a117ad 100644 --- a/Docs/source/eos_cell.rst +++ b/Docs/source/eos_cell.rst @@ -28,10 +28,8 @@ The parameters that affect the thermodynamics are: * ``unit_test.temperature`` : the initial temperature -The composition can be set in the same way as in ``burn_cell``, either -by setting each mass fraction explicitly via the parameters, -``unit_test.X1``, ``unit_test.X2``, ..., or forcing them to be all -equal via ``unit_test.uniform_xn=1``. +The composition can be set either by specifying individual mass fractions +or setting ``unit_test.uniform_xn`` as described in :ref:`sec:defining_unit_test_composition`. Building and Running the Code diff --git a/Docs/source/jac_cell.rst b/Docs/source/jac_cell.rst index a7a0bfa208..cf7a73c2bc 100644 --- a/Docs/source/jac_cell.rst +++ b/Docs/source/jac_cell.rst @@ -38,10 +38,15 @@ The parameters that affect the thermodynamics are: * ``unit_test.temperature`` : the initial temperature -While the mass fractions can be set individually (using -``unit_test.X1``, ``unit_test.X2``, ...), it is recommended to use -``unit_test.uniform_xn=1`` to initialize all the mass fractions to be -equal. +The composition can be set either by specifying individual mass fractions +or setting ``unit_test.uniform_xn`` as described in :ref:`sec:defining_unit_test_composition`. + +If the values don't sum to ``1`` initially, then the test will do a +normalization. This normalization can be disabled by setting: + +:: + + unit_test.skip_initial_normalization = 1 Building and Running the Code diff --git a/Docs/source/unit_test_runtime_parameters.rst b/Docs/source/unit_test_runtime_parameters.rst index a5cfa924f6..4584b833db 100644 --- a/Docs/source/unit_test_runtime_parameters.rst +++ b/Docs/source/unit_test_runtime_parameters.rst @@ -25,7 +25,7 @@ Most of the unit tests require a composition to be defined (for the initial mass-fractions, $X_k$). There are a few ways this can be done (depending on the test). -* One-zone (`*_cell`) tests usually do one of: +* One-zone (``*_cell``) tests usually do one of: * *Explicitly setting the individual mass fractions.* This is controlled by the parameters ``unit_test.X1``, ``unit_test.X2``, ..., ``unit_test.X35``, diff --git a/unit_test/test_sdc_vode_rhs/vode_rhs_test.H b/unit_test/test_sdc_vode_rhs/vode_rhs_test.H index 14604d4a46..8c4c89c96b 100644 --- a/unit_test/test_sdc_vode_rhs/vode_rhs_test.H +++ b/unit_test/test_sdc_vode_rhs/vode_rhs_test.H @@ -23,7 +23,7 @@ void do_vode_rhs() for (int n = 1; n <= NumSpec; ++n) { - massfractions[n-1] = get_xn(n); + massfractions[n-1] = get_xn(n, unit_test_rp::uniform_xn); if (massfractions[n-1] < 0 || massfractions[n-1] > 1) { amrex::Error("mass fraction for " + short_spec_names_cxx[n-1] + " not initialized in the interval [0,1]!");