Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work on addressing some issues with the Jacobian scaling #1479

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Feb 12, 2024

this applies if we run with scale_system=1
also as part of this change, allow the Circle theorem to use the numerical Jacobian.

this applies if we run with scale_system=1
also as part of this change, allow the Circle theorem to
use the numerical Jacobian.
@zingale zingale marked this pull request as draft February 12, 2024 20:28
@zingale
Copy link
Member Author

zingale commented Feb 12, 2024

this addresses #1242 and #1250

@zingale
Copy link
Member Author

zingale commented Feb 13, 2024

this seems to fix the scaling. For example, on development, running VODE with test_react using aprox13 and inputs_aprox13 with:

./main3d.gnu.ex inputs_aprox13

I get:

Run time = 1.375719445
min number of rhs calls: 6
avg number of rhs calls: 116
max number of rhs calls: 3932
min number of steps: 3
avg number of steps: 94
max number of steps: 3767

If I turn on scaling:

./main3d.gnu.ex inputs_aprox13 integrator.scale_system=1

then the integration is really bad:

Run time = 19.50141599
min number of rhs calls: 6
avg number of rhs calls: 1611
max number of rhs calls: 109891
min number of steps: 3
avg number of steps: 733
max number of steps: 46777

But if I run with scaling on this PR, I get:

Run time = 1.435576058
min number of rhs calls: 6
avg number of rhs calls: 117
max number of rhs calls: 3932
min number of steps: 3
avg number of steps: 94
max number of steps: 3767

almost the same as the "no scaling" result

@zingale zingale marked this pull request as ready for review February 13, 2024 19:13
@zingale zingale merged commit adb2600 into AMReX-Astro:development Feb 28, 2024
27 checks passed
@zingale zingale deleted the scaling_fixes branch February 28, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants