Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing weak rate energy to NSE update #1483

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Feb 15, 2024

This accounts for the fact that when we just do the binding energy, we don't capture the energy difference from converting protons to neutrons. That term looks like N_A (m_n - (m_p + m_e) c**2 dY_e/dt. This adds that to the SDC
update.

@zingale
Copy link
Member Author

zingale commented Feb 15, 2024

closes #1482

@zingale zingale marked this pull request as draft February 15, 2024 19:44
@zingale zingale marked this pull request as ready for review February 17, 2024 13:57
@zingale
Copy link
Member Author

zingale commented Feb 17, 2024

this seems to work really well

@zingale zingale merged commit eb1f853 into AMReX-Astro:development Feb 17, 2024
27 checks passed
@zingale zingale deleted the add_weak_loss branch February 17, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants