add option for direction-dependent bc's #136

asalmgren · 2024-07-30T02:27:28Z

No description provided.

mukul1992

I think I caught a few mistakes and some possible ones.

mukul1992 · 2024-07-30T18:38:24Z

Godunov/hydro_godunov_extrap_vel_to_faces_3D.cpp

@@ -430,7 +432,7 @@ Godunov::ExtrapVelToFacesOnBox ( Box const& bx, int ncomp,
            sth += Real(0.5) * l_dt * f(i  ,j,k,n);
        }

-        HydroBC::SetXEdgeBCs(i, j, k, n, q, stl, sth, bc.lo(0), dlo.x, bc.hi(0), dhi.x, true);
+        HydroBC::SetXEdgeBCs(i, j, k, n, q, stl, sth, stl, sth, bc.lo(0), dlo.x, bc.hi(0), dhi.x, true);


Are these calls a substitute for Godunov_cc_zbc_lo type calls in A-W? In A-W, those use u_ad/v_ad/w_ad as the "edge" velocities. Are you sure using stl/sth is correct?

Yes, on a second look, to match with A-W, these calls should be passing u_ad/v_ad/w_ad instead of stl and sth as velm and velp.

See the Godunov_cc_xbc_lo type calls in incflo_godunov_predict.cpp in A-W for reference. Note that these are coded separately from the Godunov_trans_xbc type functions in A-W. They are mostly similar in implementation though but need to make sure..

mukul1992 · 2024-07-30T18:41:55Z

Godunov/hydro_godunov_plm.H

@@ -88,7 +89,8 @@ void PredictStateOnXFace ( const int i, const int j, const int k, const int n,
            }

        }
-        else if (i == domain_ihi+1 && (bc.hi(0) == BCType::ext_dir))
+        else if (i == domain_ihi+1 && ((bc.hi(0) == BCType::ext_dir) ||
+                                       (bc.lo(0) == BCType::direction_dependent && umac <= 0.0)) )


Suggested change

(bc.lo(0) == BCType::direction_dependent && umac <= 0.0)) )

(bc.hi(0) == BCType::direction_dependent && umac <= 0.0)) )

mukul1992 · 2024-07-30T18:42:18Z

Godunov/hydro_godunov_plm.H

@@ -153,7 +156,8 @@ void PredictStateOnYFace ( const int i, const int j, const int k, const int n,
                    amrex_calc_yslope_extdir(i,j  ,k,n,order,S, extdir_or_ho_jlo, extdir_or_ho_jhi, domain_jlo, domain_jhi);
            }
        }
-        else if (j == domain_jhi+1 && (bc.hi(1) == BCType::ext_dir))
+        else if (j == domain_jhi+1 && ((bc.hi(1) == BCType::ext_dir) ||
+                                       (bc.lo(1) == BCType::direction_dependent && vmac <= 0.0)) )


Suggested change

(bc.lo(1) == BCType::direction_dependent && vmac <= 0.0)) )

(bc.hi(1) == BCType::direction_dependent && vmac <= 0.0)) )

mukul1992 · 2024-07-30T18:42:44Z

Godunov/hydro_godunov_plm.H

@@ -218,7 +223,8 @@ void PredictStateOnZFace ( const int i, const int j, const int k, const int n,
                    amrex_calc_zslope_extdir(i,j,k  ,n,order,S, extdir_or_ho_klo, extdir_or_ho_khi, domain_klo, domain_khi);
            }
        }
-        else if (k == domain_khi+1 && (bc.hi(2) == BCType::ext_dir))
+        else if (k == domain_khi+1 && ((bc.hi(2) == BCType::ext_dir) ||
+                                       (bc.lo(2) == BCType::direction_dependent && wmac <= 0.0)) )


Suggested change

(bc.lo(2) == BCType::direction_dependent && wmac <= 0.0)) )

(bc.hi(2) == BCType::direction_dependent && wmac <= 0.0)) )

mukul1992 · 2024-07-31T00:04:39Z

Godunov/hydro_godunov_extrap_vel_to_faces_2D.cpp

@@ -258,7 +259,7 @@ Godunov::ExtrapVelToFacesOnBox (Box const& bx, int ncomp,
        }

        const auto bc = HydroBC::getBC(i, j, k, n, domain, pbc, bc_arr);
-        HydroBC::SetYEdgeBCs(i, j, k, n, q, lo, hi, bc.lo(1), dlo.y, bc.hi(1), dhi.y, true);
+        HydroBC::SetYEdgeBCs(i, j, k, n, q, lo, hi, lo, hi, bc.lo(1), dlo.y, bc.hi(1), dhi.y, true);


should it be vad here instead of lo/hi?

mukul1992 · 2024-07-31T00:07:39Z

EBGodunov/hydro_ebgodunov_extrap_vel_to_faces_2D.cpp

should it be uad/vad/wad here in this file instead of lo/hi or stl/sth?

mukul1992 · 2024-07-31T00:09:41Z

EBGodunov/hydro_ebgodunov_extrap_vel_to_faces_3D.cpp

Rplace stl/sth with uad/vad/wad?

WeiqunZhang · 2024-07-31T15:50:59Z

Godunov/hydro_godunov_ppm.H

@@ -774,7 +788,8 @@ void PredictStateOnYFace ( const int i, const int j, const int k, const int n,
    amrex::Real sm, sp;
    amrex::Tie(sm,sp) = Limiter::sm_sp(s0,sedge1,sedge2);

-    SetYBCs<Limiter>(i, j, k, n, sm, sp, sedge1, sedge2, S, bc.lo(1), bc.hi(1), domlo, domhi);
+    SetYBCs<Limiter>(i, j, k, n, sm, sp, sedge1, sedge2, S, vel_edge(i,j,k), vel_edge(i+1,j,k),


vel_edge(i,j+1,k) ?

add option for direction-dependent bc's

0bd2d1a

asalmgren marked this pull request as draft July 30, 2024 02:27

missed some ...

cae9075

mukul1992 reviewed Jul 30, 2024

View reviewed changes

asalmgren added 2 commits July 30, 2024 11:52

fix typos

f0d5512

fix which velocity sent to *EdgeBCs routines

63f1982

asalmgren marked this pull request as ready for review July 30, 2024 19:36

asalmgren requested a review from WeiqunZhang July 30, 2024 19:36

mukul1992 reviewed Jul 31, 2024

View reviewed changes

EBGodunov/hydro_ebgodunov_extrap_vel_to_faces_3D.cpp Outdated

Copy link

Contributor

mukul1992 Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rplace stl/sth with uad/vad/wad?

asalmgren added 2 commits July 30, 2024 17:14

more fixes

fe5c283

fix more oops

d6abe96

WeiqunZhang reviewed Jul 31, 2024

View reviewed changes

fix typo

4936585

asalmgren marked this pull request as draft July 31, 2024 20:16

asalmgren added 3 commits August 6, 2024 06:30

use advective vel where possible in BC upwinding

b1c4918

Merge branch 'development' into add_direction_dependent_bcs

836cba0

more changes to support direction_dependent bc

ecd625f

asalmgren marked this pull request as ready for review August 6, 2024 15:08

WeiqunZhang approved these changes Aug 8, 2024

View reviewed changes

asalmgren merged commit 186df80 into AMReX-Fluids:development Aug 8, 2024
14 checks passed

asalmgren deleted the add_direction_dependent_bcs branch August 8, 2024 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add option for direction-dependent bc's #136

add option for direction-dependent bc's #136

asalmgren commented Jul 30, 2024

mukul1992 left a comment

mukul1992 Jul 30, 2024

mukul1992 Jul 30, 2024

mukul1992 Jul 30, 2024

mukul1992 Jul 30, 2024

mukul1992 Jul 30, 2024

mukul1992 Jul 31, 2024

mukul1992 Jul 31, 2024

mukul1992 Jul 31, 2024

WeiqunZhang Jul 31, 2024

	(bc.lo(0) == BCType::direction_dependent && umac <= 0.0)) )
	(bc.hi(0) == BCType::direction_dependent && umac <= 0.0)) )

	(bc.lo(1) == BCType::direction_dependent && vmac <= 0.0)) )
	(bc.hi(1) == BCType::direction_dependent && vmac <= 0.0)) )

	(bc.lo(2) == BCType::direction_dependent && wmac <= 0.0)) )
	(bc.hi(2) == BCType::direction_dependent && wmac <= 0.0)) )

add option for direction-dependent bc's #136

add option for direction-dependent bc's #136

Conversation

asalmgren commented Jul 30, 2024

mukul1992 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment