-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Week6] (#9) 6주차 과제 #10
Open
mnbvcxzyj
wants to merge
2
commits into
main
Choose a base branch
from
feature/#9_week6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
sozohoy
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 ~!
@@ -19,15 +20,18 @@ class TabBarController: UITabBarController { | |||
let financialTabMainViewController = FinancialTabMainViewController() | |||
let chartViewController = ChartViewController() | |||
let signUpViewController = SignUpViewController() | |||
let chartSwiftUIView = ChartView() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- SwiftUI는 네이밍에서 빼도 되지 않을까 싶어요!
let appList: [RankingApp] = RankingApp.chartApps | ||
|
||
var body: some View { | ||
NavigationView { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- NavigationStack으로 한다면 어떻게 수정해야 할까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 작업 내용
let chartSwiftUIHostingController = UIHostingController(rootView: chartSwiftUIView)
를 사용해서 기존 UIKit을 사용하는 탭바에 SwiftUI뷰를 추가했습니다.📸 스크린샷