-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodejs-22: backport corepack update to 0.31.0 #9597
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This backports node update of corepack to 0.31.0, updating npmjs.org keys pinned by corepack. The patch should be removed after nodejs 22.14.0 proposal gets released. This should fix the following error: corepack install -g pnpm@10.2.1 Installing pnpm@10.2.1... Internal Error: Cannot find matching keyid: {"signatures":[{"sig":"MEYCIQDkZyZZmBzkRcQowEEFiEcGp4/xV8GBLXxTEzz9QstrsAIhAPx6tvZixjTub6GPqJa82vcWFhUU39JCtoJvcoRK/K39","keyid":"SHA256:DhQ8wR5APBvFHLF/+Tc+AYvPOdTpcIDqOhxsBHRwC7U"}],"keys":[{"expires":null,"keyid":"SHA256:jl3bwswu80PjjokCgh0o2w5c2U4LhQAE57gj9cz1kzA","keytype":"ecdsa-sha2-nistp256","scheme":"ecdsa-sha2-nistp256","key":"MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAE1Olb3zMAFFxXKHiIkQO5cJ3Yhl5i6UPp+IhuteBJbuHcA5UogKo0EWtlWwW6KSaKoTNEYL7JlCQiVnkhBktUgg=="}]} Link: nodejs/node#56910 Link: pnpm/pnpm#9014 Link: nodejs/corepack#612 Link: misskey-dev/misskey#15386 Link: https://github.com/nodejs/corepack/releases/tag/v0.31.0 Link: nodejs/node@63c1859 Link: nodejs/node#56795 Backport-of: 63c1859e019465cbb0b6b46ba0d481fb41d94a22 Reviewed-by: xtex <xtex@aosc.io> Signed-off-by: xtex <xtex@aosc.io>
KexyBiscuit
approved these changes
Feb 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
OriginCode
approved these changes
Feb 8, 2025
xtexx
added a commit
that referenced
this pull request
Feb 8, 2025
This resolves the same error as in PR 9597 for nodejs 20.x, updating Corepack's pinned registry public keys. Patch 1 (update corepack to 0.30.0) is included in nodejs v20.18.3 proposal and should be removed in the next nodejs update. Patch 2 (update to 0.31.0) is not included in that proposal and should be removed after two new nodejs 20.x releases. Link: nodejs/node#56699 Link: nodejs/corepack#627 Link: https://github.com/nodejs/corepack/releases/tag/v0.31.0 Link: https://github.com/nodejs/corepack/releases/tag/v0.30.0 Link: nodejs/node@f7131cf Link: nodejs/node@63c1859 Link: nodejs/node#55977 Link: nodejs/node#56795 Link: #9597 Backport-of: f7131cf178231f578f1da2aa7ff52a427c953b98 Backport-of: 64ee8a025815553af30d9d273e2f2d07a5eb83ea Reviewed-by: xtex <xtex@aosc.io> Signed-off-by: xtex <xtex@aosc.io>
6 tasks
MingcongBai
pushed a commit
that referenced
this pull request
Feb 9, 2025
This resolves the same error as in PR 9597 for nodejs 20.x, updating Corepack's pinned registry public keys. Patch 1 (update corepack to 0.30.0) is included in nodejs v20.18.3 proposal and should be removed in the next nodejs update. Patch 2 (update to 0.31.0) is not included in that proposal and should be removed after two new nodejs 20.x releases. Link: nodejs/node#56699 Link: nodejs/corepack#627 Link: https://github.com/nodejs/corepack/releases/tag/v0.31.0 Link: https://github.com/nodejs/corepack/releases/tag/v0.30.0 Link: nodejs/node@f7131cf Link: nodejs/node@63c1859 Link: nodejs/node#55977 Link: nodejs/node#56795 Link: #9597 Backport-of: f7131cf178231f578f1da2aa7ff52a427c953b98 Backport-of: 64ee8a025815553af30d9d273e2f2d07a5eb83ea Reviewed-by: xtex <xtex@aosc.io> Signed-off-by: xtex <xtex@aosc.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic Description
This backports node update of corepack to 0.31.0, updating npmjs.org
keys pinned by corepack.
The patch should be removed after nodejs 22.14.0 proposal gets released.
This should fix the following error:
corepack install -g pnpm@10.2.1
Installing pnpm@10.2.1...
Internal Error: Cannot find matching keyid: {"signatures":[{"sig":"MEYCIQDkZyZZmBzkRcQowEEFiEcGp4/xV8GBLXxTEzz9QstrsAIhAPx6tvZixjTub6GPqJa82vcWFhUU39JCtoJvcoRK/K39","keyid":"SHA256:DhQ8wR5APBvFHLF/+Tc+AYvPOdTpcIDqOhxsBHRwC7U"}],"keys":[{"expires":null,"keyid":"SHA256:jl3bwswu80PjjokCgh0o2w5c2U4LhQAE57gj9cz1kzA","keytype":"ecdsa-sha2-nistp256","scheme":"ecdsa-sha2-nistp256","key":"MFkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDQgAE1Olb3zMAFFxXKHiIkQO5cJ3Yhl5i6UPp+IhuteBJbuHcA5UogKo0EWtlWwW6KSaKoTNEYL7JlCQiVnkhBktUgg=="}]}
Link: 22.14.0 'Jod' (LTS) release proposal nodejs/node#56910
Link: Installing pnpm 10.1.0 on windows fails with
cannot find matching keyid
pnpm/pnpm#9014Link: Newly published versions of package managers distributed from npm cannot be installed due to key id mismatch nodejs/corepack#612
Link: Signatures changed in the latest version of
pnpm
misskey-dev/misskey#15386Link: https://github.com/nodejs/corepack/releases/tag/v0.31.0
Link: nodejs/node@63c1859
Link: deps: update corepack to 0.31.0 nodejs/node#56795
Backport-of: 63c1859e019465cbb0b6b46ba0d481fb41d94a22
Reviewed-by: xtex xtex@aosc.io
Signed-off-by: xtex xtex@aosc.io
Package(s) Affected
Security Update?
No
Build Order
Test Build(s) Done
Primary Architectures
amd64
arm64
loongarch64
Secondary Architectures
loongson3
ppc64el
riscv64