From 0ed71aa59671f249744f19bd6aced6df5e35b74e Mon Sep 17 00:00:00 2001 From: bryanyee33 Date: Sat, 13 Apr 2024 00:15:50 +0800 Subject: [PATCH] Improve PersonMatchesQueryPredicate test cases --- .../person/PersonMatchesQueryPredicateTest.java | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/test/java/seedu/address/model/person/PersonMatchesQueryPredicateTest.java b/src/test/java/seedu/address/model/person/PersonMatchesQueryPredicateTest.java index d2a4bfa0799..33fc19e42db 100644 --- a/src/test/java/seedu/address/model/person/PersonMatchesQueryPredicateTest.java +++ b/src/test/java/seedu/address/model/person/PersonMatchesQueryPredicateTest.java @@ -61,6 +61,14 @@ public void test_nameMatchesQuery_returnsTrue() { // Query without whitespace predicate = new PersonMatchesQueryPredicate("xy"); assertTrue(predicate.test(new PersonBuilder().withName("Alex Yeoh").build())); + + // Query without tags + predicate = new PersonMatchesQueryPredicate("Alice Bob"); + assertTrue(predicate.test(new PersonBuilder().withName("Alice Bob").withTags(new String[0]).build())); + + // Query without assets + predicate = new PersonMatchesQueryPredicate("Alice Bob"); + assertTrue(predicate.test(new PersonBuilder().withName("Alice Bob").withAssets(new String[0]).build())); } @Test @@ -120,6 +128,10 @@ public void test_tagMatchesQuery_returnsTrue() { // Short query, long tag predicate = new PersonMatchesQueryPredicate("a"); assertTrue(predicate.test(new PersonBuilder().withTags("colleagues").build())); + + // No assets + predicate = new PersonMatchesQueryPredicate("friends"); + assertTrue(predicate.test(new PersonBuilder().withTags("friends").withAssets(new String[0]).build())); } @Test @@ -150,6 +162,10 @@ public void test_assetMatchesQuery_returnsTrue() { // Query without whitespace predicate = new PersonMatchesQueryPredicate("rsc"); assertTrue(predicate.test(new PersonBuilder().withAssets("hammer screw").build())); + + // No tags + predicate = new PersonMatchesQueryPredicate("hammer"); + assertTrue(predicate.test(new PersonBuilder().withAssets("hammer").withTags(new String[0]).build())); } @Test