Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor models component: abstract out Set<Tag> into Tags.java #8

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

aureliony
Copy link

No description provided.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 79.06977% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 74.30%. Comparing base (dfb1e3d) to head (804bd73).

Files Patch % Lines
src/main/java/seedu/address/ui/PersonCard.java 0.00% 6 Missing ⚠️
...n/java/seedu/address/model/person/fields/Tags.java 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master       #8      +/-   ##
============================================
+ Coverage     74.22%   74.30%   +0.08%     
- Complexity      405      409       +4     
============================================
  Files            69       70       +1     
  Lines          1284     1292       +8     
  Branches        116      111       -5     
============================================
+ Hits            953      960       +7     
- Misses          301      302       +1     
  Partials         30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few nits to fix..

Copy link

@bryanyee33 bryanyee33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bryanyee33 bryanyee33 merged commit 8f4d0af into AY2324S2-CS2103T-W12-3:master Feb 29, 2024
5 checks passed
@aureliony aureliony added this to the v1.2 milestone Mar 1, 2024
@aureliony aureliony changed the title Refactor models component Refactor models component: abstract out Set<Tag> into Tags.java Mar 1, 2024
@aureliony aureliony linked an issue Mar 1, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the existing codebase: storage and model components
2 participants