Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove compat dance connecting Zeq_bool and Z.eqb #535

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

andres-erbsen
Copy link
Contributor

No description provided.

@andres-erbsen andres-erbsen changed the title use Z.eqb_eq instead of Z.eqb_compare (for coq/coq#19801) remove compat dance connecting Zeq_bool and Z.eqb Nov 4, 2024
@xavierleroy
Copy link
Contributor

Sure, it works fine, CI is green. Still, this is a revert of #524. @proux01 was very insistent that #524 must be merged ASAP. Could you two talk to each other and come up with a coordinated plan of action? CompCert is not the place to have an edit war. Thank you.

@proux01
Copy link
Contributor

proux01 commented Nov 5, 2024

Yes, please don't revert #524 for now. We still need to discuss this on Coq side.

@proux01
Copy link
Contributor

proux01 commented Jan 9, 2025

@xavierleroy sorry for the unfortunate situation here, upstream PR coq/coq#19801 just got merged, please merge this now (we unfortunately had to make this a synchronous overlay, meaning Coq CI will remain broken until this is merged)

@xavierleroy xavierleroy marked this pull request as ready for review January 9, 2025 12:21
@xavierleroy
Copy link
Contributor

Closing and reopening so as to force a CI run.

@xavierleroy xavierleroy closed this Jan 9, 2025
@xavierleroy xavierleroy reopened this Jan 9, 2025
@xavierleroy xavierleroy merged commit 3bc43fc into AbsInt:master Jan 9, 2025
14 checks passed
@proux01
Copy link
Contributor

proux01 commented Jan 9, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants