-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#262: Full Flyway integration #276
Conversation
* numbered the SQL scripts for Flyway * changed `PartitioningForDB` class to contain `keysToValuesMap` instead of `keysToValues` according to validation * added sbt alias `testAll` for running all tests * database test for validation function moved to proper folder * set `flywayBaselineVersion` for upgrade purposes
JaCoCo model module code coverage report - scala 2.13.11
|
JaCoCo agent module code coverage report - scala 2.13.11
|
JaCoCo reader module code coverage report - scala 2.13.11
|
JaCoCo server module code coverage report - scala 2.13.11
|
Release notes: |
database/src/main/postgres/validation/V0.2.0.6__validate_partitioning.sql
Outdated
Show resolved
Hide resolved
database/src/main/postgres/validation/V0.2.0.7__is_partitioning_valid.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, found a few minor things. But I want to ask: why the numbering like this? For example there is no V0.1.0.3.{sql|ddl}
file, so there are gaps. There is V0.1.0.30.ddl
instead. So we don't want increments?
…-full-flyway-integration # Conflicts: # database/src/test/scala/za/co/absa/atum/database/runs/GetPartitioningCheckpointsIntegrationTests.scala
It is incremental, but with gaps. |
PartitioningForDB
class to containkeysToValuesMap
instead ofkeysToValues
according to validationtestAll
for running all testsflywayBaselineVersion
for upgrade purposesWhile it's almost 70 files, changes are minimal. In majority of cases it's just a rename.
For the actual upgrade deployment these steps are necessary:
Manual:
sbt -Dflyway.url=<target db url> -Dflyway.password=<postgres user password> flywayBaseline
Add to deployment automation
sbt -Dflyway.url=<target db url> -Dflyway.password=<postgres user password> flywayMigrate
where
<target db url>
is the database towards which the deployment is running, e.g. "jdbc:postgresql://localhost:5432/atum_db"<postgres user password>
is the password for the postgres super user at the above databaseDepends on #265
Depends on #267
Depends on #272
Depends on #275
Closes #262
Release notes: