-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/doobie with status #106
Conversation
…ts and mixed into db functions with status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed only part of the PR, but anyway I don't feel I know enough internals of fa-db to approve.
File |
Jacoco doesn't seem to work here, can you take a look @miroslavpojer please? Perhaps this is something you encountered before |
core/src/test/scala/za/co/absa/fadb/naming/ExplicitNamingRequiredTest.scala
Show resolved
Hide resolved
core/src/test/scala/za/co/absa/fadb/naming/implementations/AsIsNamingTest.scala
Show resolved
Hide resolved
Seems that the license formatting was off. The license check passes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (just read the code), though as I said I don't have much fa-db internals knowledge.
JaCoCo code coverage report - scala 2.13.12
|
In this PR, the below listed issues have been addressed:
I am aware that this pull request contains a substantial number of changes. I understand that this can make the review process more challenging and time-consuming, and I appreciate your efforts in ensuring our codebase maintains its high quality.
I am fully aware that the volume of changes may be overwhelming, and it's important to me that everyone on the team feels comfortable with these updates. To that end, I am more than willing to walk anyone through the code changes, explain the reasoning behind each modification, and answer any questions you may have.
Please feel free to reach out to me at your convenience if you would like a walkthrough of the code or if you have any questions or concerns.
Please review the changes and provide your feedback.
Closes #11
Closes #51
Closes #99
Closes #104
Closes #105