- Fix of review comments.

AbsaOSS · Dec 9, 2024 · 3bd9b0f · 3bd9b0f
1 parent 669302e
commit 3bd9b0f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/release_notes_generator/generator.py b/release_notes_generator/generator.py
@@ -81,7 +81,7 @@ def generate(self) -> Optional[str]:
             return None
 
         # get the latest release
-        rls = self.get_latest_release(repo)
+        rls: GitRelease = self.get_latest_release(repo)
 
         # default is repository creation date if no releases OR created_at of latest release
         since = rls.created_at if rls else repo.created_at
@@ -136,15 +136,15 @@ def get_latest_release(self, repo: Repository) -> Optional[GitRelease]:
         """
         if ActionInputs.is_from_tag_name_defined():
             logger.info("Getting latest release by from-tag name %s", ActionInputs.get_tag_name())
-            rls = self._safe_call(repo.get_release)(ActionInputs.get_from_tag_name())
+            rls: GitRelease = self._safe_call(repo.get_release)(ActionInputs.get_from_tag_name())
 
             if rls is None:
                 logger.info("Latest release not found for received tag %s. Ending!", ActionInputs.get_from_tag_name())
                 sys.exit(1)
 
         else:
             logger.info("Getting latest release by time.")
-            rls = self._safe_call(repo.get_latest_release)()
+            rls: GitRelease = self._safe_call(repo.get_latest_release)()
 
             if rls is None:
                 logger.info("Latest release not found for %s. 1st release for repository!", repo.full_name)

diff --git a/tests/test_action_inputs.py b/tests/test_action_inputs.py
@@ -127,6 +127,7 @@ def test_get_skip_release_notes_label(mocker):
     mocker.patch("release_notes_generator.action_inputs.get_action_input", return_value="skip-release-notes")
     assert ActionInputs.get_skip_release_notes_labels() == ["skip-release-notes"]
 
+
 def test_get_skip_release_notes_label_not_defined(mocker):
     mocker.patch("release_notes_generator.action_inputs.get_action_input", return_value="")
     assert ActionInputs.get_skip_release_notes_labels() == ["skip-release-notes"]
@@ -135,10 +136,12 @@ def test_get_skip_release_notes_labels(mocker):
     mocker.patch("release_notes_generator.action_inputs.get_action_input", return_value="skip-release-notes, another-skip-label")
     assert ActionInputs.get_skip_release_notes_labels() == ["skip-release-notes", "another-skip-label"]
 
+
 def test_get_skip_release_notes_labels_no_space(mocker):
     mocker.patch("release_notes_generator.action_inputs.get_action_input", return_value="skip-release-notes,another-skip-label")
     assert ActionInputs.get_skip_release_notes_labels() == ["skip-release-notes", "another-skip-label"]
 
+
 def test_get_print_empty_chapters(mocker):
     mocker.patch("release_notes_generator.action_inputs.get_action_input", return_value="true")
     assert ActionInputs.get_print_empty_chapters() is True

diff --git a/tests/test_release_notes_generator.py b/tests/test_release_notes_generator.py
@@ -76,7 +76,6 @@ def test_generate_release_notes_latest_release_not_found(
 
     release_notes = ReleaseNotesGenerator(github_mock, custom_chapters).generate()
 
-    print(release_notes)
     assert release_notes is not None
     assert "- #121 _Fix the bug_" in release_notes
     assert "- #122 _I1+bug_" in release_notes