Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/53 chapter line duplicity control custom and service chapters #72

Conversation

miroslavpojer
Copy link
Collaborator

@miroslavpojer miroslavpojer commented Sep 16, 2024

  • Implemented duplicity logic in form of prefix icon.
  • Added check for duplicity conditions.
  • Update of unit tests.

Closes #53

- Implemented two new input parameters 'duplicity-scope' and 'duplicity-icon'.
- Update of unit tests for Inputs validation.
- Fix several pylint issues.
- Implemented duplicity logic in form of prefix icon.
- Added check for duplicity conditions.
- Update of unit tests.
@miroslavpojer
Copy link
Collaborator Author

Release notes:

  • Implemented duplicity logic in the form of prefix icon.

Copy link

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix or comment my suggestions and questions below.

Copy link

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, after comment discussion.

@miroslavpojer miroslavpojer merged commit d5751a9 into master Sep 20, 2024
4 checks passed
@miroslavpojer miroslavpojer deleted the feature/53-Chapter-line-duplicity-control---custom-and-service-chapters branch September 20, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chapter line duplicity control - custom and service chapters
2 participants