Feature/qt6 - Remove usage of Core5Compat library #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cédrik Fuoco <cedrik.fuoco@autodesk.com>
cedrik-fuoco-adsk
requested review from
bernie-laberge and
eloisebrosseau
as code owners
Comment on lines
+373
to
+382
| #if defined(RV_VFX_CY2023) | ||
| QTextCodec* codec = QTextCodec::codecForHtml(array); | ||
| QString u = codec->toUnicode(array); | ||
| #else | ||
| // Assume that the data is utf-8 encoded because about 98-99% of | ||
| // websites uses utf-8. The second closest is ISO-8859-1 | ||
| // with 1.1%. | ||
| QStringDecoder decoder(QStringDecoder::Utf8); | ||
| QString u = decoder.decode(array); | ||
| #endif |
There was a problem hiding this comment.
@bernie-laberge @eloisebrosseau Is this a reasonable assumption?
There was a problem hiding this comment.
Yes. I believe this is a valid assumption.
In any case, this code path is no longer used by RV anymore. So I think this is good enough.
There was a problem hiding this comment.
I did a quick search, and I also believe we can make that assumption
eloisebrosseau
approved these changes
Mar 7, 2025
Comment on lines
+373
to
+382
| #if defined(RV_VFX_CY2023) | ||
| QTextCodec* codec = QTextCodec::codecForHtml(array); | ||
| QString u = codec->toUnicode(array); | ||
| #else | ||
| // Assume that the data is utf-8 encoded because about 98-99% of | ||
| // websites uses utf-8. The second closest is ISO-8859-1 | ||
| // with 1.1%. | ||
| QStringDecoder decoder(QStringDecoder::Utf8); | ||
| QString u = decoder.decode(array); | ||
| #endif |
There was a problem hiding this comment.
I did a quick search, and I also believe we can make that assumption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature/qt6 - Remove usage of Core5Compat library
Linked issues
n/a
Summarize your change.
I have eliminated all instances of QTextCodec, as this class is no longer supported in Qt 6. Previously, the code relied on the Core5Compat library, which incorporates deprecated and obsolete Qt 5 classes.
Describe what you have tested and on which operating system.
I created a python plugin to execute the httpGet method from the RvWebManager class.