Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BP Graph CSFun. #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

BP Graph CSFun. #40

wants to merge 1 commit into from

Conversation

ASY13
Copy link

@ASY13 ASY13 commented Jul 22, 2022

No description provided.

Copy link

@kyra-patton kyra-patton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐶🐾 Very nice work, Andrea! I left a couple comments on the time complexity and an edge case. Let me know what questions you have.

🟢

@@ -5,8 +5,48 @@ def possible_bipartition(dislikes):
""" Will return True or False if the given graph
can be bipartitioned without neighboring nodes put
into the same partition.
Time Complexity: ?
Space Complexity: ?
Time Complexity: O(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱ Time complexity would actually be O(N + E) where N is the number of nodes (aka dogs) in the graph and E is the number of edges (dislike between two dogs) in the graph represented by dislikes. This is because you visit each edge and each node exactly once.

Comment on lines +20 to +23
if dislikes[0]:
start = 0
else:
start = 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imagine a graph that has multiple disconnected nodes stored at the beginning of the adjacency list dislikes. How might you refactor your code to account for this edge case?

left.add(start)


while len(deck) != 0:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐩 Very nice BFS solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants