Linked List Assignment #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Mar 31, 2022
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
This could probably be added to .gitignore
Comment on lines
+23
to
26
| Time Complexity: O(1) | ||
| Space Complexity: O(1) | ||
| */ | ||
| getFirst() { |
Comment on lines
+33
to
36
| Time Complexity: O(1) | ||
| Space Complexity: O(1) | ||
| */ | ||
| addFirst(value) { |
Comment on lines
+49
to
52
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| search(value) { |
Comment on lines
+65
to
68
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| length() { |
Comment on lines
+169
to
172
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| visit() { |
There was a problem hiding this comment.
👍 Space complexity of O(n) because you're building a list.
Comment on lines
+187
to
190
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| reverse() { |
Comment on lines
+211
to
214
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| findMiddleValue() { |
There was a problem hiding this comment.
👍 Good reuse of existing methods and arithmetic.
Comment on lines
+224
to
227
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| findNthFromEnd(n) { |
There was a problem hiding this comment.
👍 Good reuse of existing methods and arithmetic.
Comment on lines
+235
to
238
| Time Complexity: O(n) | ||
| Space Complexity: O(1) | ||
| */ | ||
| hasCycle() { |
There was a problem hiding this comment.
What if the loop isn't back to the `head? What if it loops back to the 3rd node in the list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.