C16 - Cedar - Afina #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Mar 31, 2022
Comment on lines
+15
to
21
| constructor(head = null, tail = null, length = 0) { | ||
| // The # before the variable name indicates | ||
| // a private variable. | ||
| this.#head = null; | ||
| this.#head = head; | ||
| this.tail = tail; | ||
| this.#length = length; | ||
| } |
| Time Complexity: O(1) | ||
| Space Complexity: O(1) | ||
| */ | ||
| getFirst() { | ||
| throw new Error('This method has\'t been implemented yet!') |
Comment on lines
+36
to
39
| Time Complexity: O(1) | ||
| Space Complexity: O(1) | ||
| */ | ||
| addFirst(value) { |
Comment on lines
+55
to
58
| Time Complexity: O(N) | ||
| Space Complexity: O(1) | ||
| */ | ||
| search(value) { |
Comment on lines
+76
to
79
| Time Complexity: O(1) | ||
| Space Complexity: O(1) | ||
| */ | ||
| length() { |
Comment on lines
+139
to
142
| Time Complexity: O(N) | ||
| Space Complexity: O(1) | ||
| */ | ||
| findMax() { |
Comment on lines
+161
to
164
| Time Complexity: O(N) | ||
| Space Complexity: O(1) | ||
| */ | ||
| delete(value) { |
There was a problem hiding this comment.
👍 Nicely done. I do want to note that this becomes a bit easier with a doubly linked list (you don't need the previous reference).
Comment on lines
+202
to
205
| Time Complexity: O(N) | ||
| Space Complexity: O(N) | ||
| */ | ||
| visit() { |
Comment on lines
+221
to
224
| Time Complexity: O(N) | ||
| Space Complexity: O(N) | ||
| */ | ||
| reverse() { |
There was a problem hiding this comment.
👍 However the space complexity is O(1)
Comment on lines
+246
to
249
| Time Complexity: O(N) | ||
| Space Complexity: O(1) | ||
| */ | ||
| findMiddleValue() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.