-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ainur - C16 Pine #55
base: master
Are you sure you want to change the base?
Ainur - C16 Pine #55
Changes from all commits
1b1cc1b
12e5ec7
164c0df
0f16636
cf7abad
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -13,67 +13,125 @@ def __init__(self): | |||||||
|
||||||||
# returns the value in the first node | ||||||||
# returns None if the list is empty | ||||||||
# Time Complexity: ? | ||||||||
# Space Complexity: ? | ||||||||
# Time Complexity: O(1) | ||||||||
# Space Complexity: O(1) | ||||||||
def get_first(self): | ||||||||
pass | ||||||||
if self.head == None: | ||||||||
return None | ||||||||
return self.head.value | ||||||||
|
||||||||
|
||||||||
# method to add a new node with the specific data value in the linked list | ||||||||
# insert the new node at the beginning of the linked list | ||||||||
# Time Complexity: ? | ||||||||
# Space Complexity: ? | ||||||||
# Time Complexity: O(1) | ||||||||
# Space Complexity: O(1) | ||||||||
def add_first(self, value): | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||||||
pass | ||||||||
self.head = Node(value, self.head) | ||||||||
|
||||||||
# method to find if the linked list contains a node with specified value | ||||||||
# returns true if found, false otherwise | ||||||||
# Time Complexity: ? | ||||||||
# Space Complexity: ? | ||||||||
# Time Complexity: O(n) | ||||||||
# Space Complexity: O(1) | ||||||||
def search(self, value): | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||||||
pass | ||||||||
current = self.head | ||||||||
while current != None: | ||||||||
if current.value == value: | ||||||||
return True | ||||||||
current = current.next | ||||||||
return False | ||||||||
|
||||||||
# method that returns the length of the singly linked list | ||||||||
# Time Complexity: ? | ||||||||
# Space Complexity: ? | ||||||||
# Time Complexity: O(n) | ||||||||
# Space Complexity: O(1) | ||||||||
def length(self): | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||||||
pass | ||||||||
count = 0 | ||||||||
current = self.head | ||||||||
while current != None: | ||||||||
count += 1 | ||||||||
current = current.next | ||||||||
return count | ||||||||
|
||||||||
|
||||||||
# method that returns the value at a given index in the linked list | ||||||||
# index count starts at 0 | ||||||||
# returns None if there are fewer nodes in the linked list than the index value | ||||||||
# Time Complexity: ? | ||||||||
# Space Complexity: ? | ||||||||
# Time Complexity: O(n) | ||||||||
# Space Complexity: O(1) | ||||||||
def get_at_index(self, index): | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||||||
pass | ||||||||
current = self.head | ||||||||
current_index = 0 | ||||||||
|
||||||||
while current != None: | ||||||||
if current_index == index: | ||||||||
return current.value | ||||||||
current_index += 1 | ||||||||
current = current.next | ||||||||
return None | ||||||||
|
||||||||
# method that returns the value of the last node in the linked list | ||||||||
# returns None if the linked list is empty | ||||||||
# Time Complexity: ? | ||||||||
# Space Complexity: ? | ||||||||
# Time Complexity: O(n) or O(1) | ||||||||
# Space Complexity: O(1) | ||||||||
def get_last(self): | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ However, when would this implementation be O(1)? |
||||||||
pass | ||||||||
if self.head == None: | ||||||||
return None | ||||||||
current = self.head | ||||||||
while current.next != None: | ||||||||
current = current.next | ||||||||
return current.value | ||||||||
|
||||||||
# method that inserts a given value as a new last node in the linked list | ||||||||
# Time Complexity: ? | ||||||||
# Space Complexity: ? | ||||||||
# Time Complexity: O(n) or O(1) | ||||||||
# Space Complexity: O(1) | ||||||||
def add_last(self, value): | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ In which cases would the time complexity be O(1)? |
||||||||
pass | ||||||||
new_node = Node(value) | ||||||||
if self.head == None: | ||||||||
self.head = new_node | ||||||||
return new_node | ||||||||
current = self.head | ||||||||
|
||||||||
while current.next != None: | ||||||||
current = current.next | ||||||||
current.next = new_node | ||||||||
|
||||||||
# method to return the max value in the linked list | ||||||||
# returns the data value and not the node | ||||||||
def find_max(self): | ||||||||
pass | ||||||||
if self.head == None: | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||||||
return None | ||||||||
current = self.head | ||||||||
current_max = self.head.value | ||||||||
|
||||||||
|
||||||||
while current != None: | ||||||||
if current_max < current.value: | ||||||||
current_max = current.value | ||||||||
current = current.next | ||||||||
return current_max | ||||||||
|
||||||||
# method to delete the first node found with specified value | ||||||||
# Time Complexity: ? | ||||||||
# Space Complexity: ? | ||||||||
# Time Complexity: O(n) | ||||||||
# Space Complexity: O(1) | ||||||||
def delete(self, value): | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ Good on space and time complexity, however see comments below ⬇️ |
||||||||
pass | ||||||||
current = self.head | ||||||||
prev = None | ||||||||
while current != None: | ||||||||
if current.value == value: | ||||||||
if current == self.head: | ||||||||
self.head = self.head.next | ||||||||
current = self.head | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤔 At this point, I would recommend exiting the function. Otherwise, you will continue iterating through and end up deleting _all_nodes found with the specified value. This method only asks you to delete the first.
Suggested change
|
||||||||
else: | ||||||||
prev.next = current.next | ||||||||
current = current.next | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again, once you have found the value, you can stop looping
Suggested change
|
||||||||
else: | ||||||||
prev = current | ||||||||
current = current.next | ||||||||
|
||||||||
return self.head | ||||||||
|
||||||||
# method to print all the values in the linked list | ||||||||
# Time Complexity: ? | ||||||||
# Space Complexity: ? | ||||||||
# Time Complexity: O(n) | ||||||||
# Space Complexity: O(1) | ||||||||
def visit(self): | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||||||
helper_list = [] | ||||||||
current = self.head | ||||||||
|
@@ -86,32 +144,66 @@ def visit(self): | |||||||
|
||||||||
# method to reverse the singly linked list | ||||||||
# note: the nodes should be moved and not just the values in the nodes | ||||||||
# Time Complexity: ? | ||||||||
# Space Complexity: ? | ||||||||
# Time Complexity: O(n) | ||||||||
# Space Complexity: O(1) | ||||||||
def reverse(self): | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||||||
pass | ||||||||
|
||||||||
|
||||||||
current = self.head | ||||||||
prev = None | ||||||||
while current != None: | ||||||||
next = current.next | ||||||||
current.next = prev | ||||||||
prev = current | ||||||||
current = next | ||||||||
self.head = prev | ||||||||
## Advanced/ Exercises | ||||||||
# returns the value at the middle element in the singly linked list | ||||||||
# Time Complexity: ? | ||||||||
# Space Complexity: ? | ||||||||
# Time Complexity: O(n) | ||||||||
# Space Complexity: O(1) | ||||||||
def find_middle_value(self): | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||||||
pass | ||||||||
slow = self.head | ||||||||
fast = self.head | ||||||||
while fast != None and fast.next != None: | ||||||||
fast = fast.next.next | ||||||||
slow = slow.next | ||||||||
return slow.value | ||||||||
|
||||||||
# find the nth node from the end and return its value | ||||||||
# assume indexing starts at 0 while counting to n | ||||||||
# Time Complexity: ? | ||||||||
# Space Complexity: ? | ||||||||
# Time Complexity: O(n) | ||||||||
# Space Complexity: O(1) | ||||||||
def find_nth_from_end(self, n): | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ Nice! |
||||||||
pass | ||||||||
if self.head == None: | ||||||||
return None | ||||||||
temp = self.head | ||||||||
length = 0 | ||||||||
while temp != None: | ||||||||
current = temp.next | ||||||||
length += 1 | ||||||||
|
||||||||
if n > length: | ||||||||
return None | ||||||||
current = self.head | ||||||||
for i in range(0, length-n): | ||||||||
current = current.next | ||||||||
return current.value | ||||||||
|
||||||||
|
||||||||
# checks if the linked list has a cycle. A cycle exists if any node in the | ||||||||
# linked list links to a node already visited. | ||||||||
# returns true if a cycle is found, false otherwise. | ||||||||
# Time Complexity: ? | ||||||||
# Space Complexity: ? | ||||||||
# Time Complexity: O(n) | ||||||||
# Space Complexity: O(1) | ||||||||
def has_cycle(self): | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✨ |
||||||||
pass | ||||||||
slow = self.head | ||||||||
fast = self.head | ||||||||
|
||||||||
while fast != None and fast.next != None: | ||||||||
slow = slow.next | ||||||||
fast = fast.next.next | ||||||||
if slow == fast: | ||||||||
return True | ||||||||
return False | ||||||||
|
||||||||
# Helper method for tests | ||||||||
# Creates a cycle in the linked list for testing purposes | ||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨