Maple - Monica C. #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spitsfire
reviewed
Jul 12, 2022
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first(self): |
Comment on lines
+28
to
+30
| new_node = Node(value) | ||
| new_node.next = self.head | ||
| self.head = new_node |
There was a problem hiding this comment.
this works just fine! We can also exploit the default parameter in the Node class and add the next pointer all at once:
Suggested change
| new_node = Node(value) | |
| new_node.next = self.head | |
| self.head = new_node | |
| self.head = Node(value, self.head) |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(self, value): |
| def search(self, value): | ||
| pass | ||
| current_node = self.head | ||
| while current_node is not None: |
There was a problem hiding this comment.
we can shorten this to:
Suggested change
| while current_node is not None: | |
| while current_node: |
| pass | ||
| node_count = 0 | ||
| current_node = self.head | ||
| while current_node is not None: |
There was a problem hiding this comment.
Suggested change
| while current_node is not None: | |
| while current_node: |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def delete(self, value): |
| current_node = current_node.next | ||
|
|
||
| # When last node is found, I want to append new_node to it. | ||
| current_node.next = new_node | ||
|
|
||
| # method to return the max value in the linked list | ||
| # returns the data value and not the node | ||
| def find_max(self): |
| current_node = current_node.next | ||
|
|
||
| previous_node.next = current_node.next | ||
| current_node = None |
There was a problem hiding this comment.
Suggested change
| current_node = None |
| # Time Complexity: ? | ||
| # Space Complexity: ? | ||
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def reverse(self): |
Comment on lines
+178
to
+179
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) |
There was a problem hiding this comment.
your time/space complexity is correct! But how could we solve this so that we don't need to make new data structures? How could we use a few pointers that keep track of the previous node, the current node, and the next node?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.