Leticia-cedar #68
Open
Leticia-cedar #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 30, 2021 19:04
beccaelenzil
reviewed
Dec 1, 2021
Comment on lines
+20
to
+21
| <h2> A little bit about me...</h2> | ||
| <section> |
There was a problem hiding this comment.
Minor note: Consider including this <h2> within the <section>. An html validator had this to say (https://www.freeformatter.com/): "Section lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all sections.
There was a problem hiding this comment.
or we could use a <p> tag with a class name to apply styling
<p class="about-me-paragraph"> Lorem ipsum </p>
| <body> | ||
|
|
There was a problem hiding this comment.
The tag is used differently on the different pages. A good convention to follow is organizing each page wth a
, then , then
Comment on lines
+20
to
+22
| <h3> | ||
| Click below to view some of my work on GitHub. | ||
| </h3> |
There was a problem hiding this comment.
Suggested change
| <h3> | |
| Click below to view some of my work on GitHub. | |
| </h3> | |
| <h2 class="subheading"> | |
| Click below to view some of my work on GitHub. | |
| </h2> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions