Cedar Rae #73
Open
Cedar Rae #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidamasaki
reviewed
Dec 3, 2021
Comment on lines
+15
to
+17
| <div class="intro"> | ||
| <h1>About Me</h1> | ||
| </div> |
There was a problem hiding this comment.
A <header> would have been more appropriate here:
Suggested change
| <div class="intro"> | |
| <h1>About Me</h1> | |
| </div> | |
| <header class="intro"> | |
| <h1>About Me</h1> | |
| </header> |
Comment on lines
+23
to
+25
| <div class="git-link"> | ||
| <button onclick="window.location.href='https://github.com/raeelwell';"">GitHub</button> | ||
| </div> |
There was a problem hiding this comment.
While the button is cool it's probably overkill to do an onclick:
You can do something similar by just wrapping the button in a link:
Suggested change
| <div class="git-link"> | |
| <button onclick="window.location.href='https://github.com/raeelwell';"">GitHub</button> | |
| </div> | |
| <a href="https://github.com/raeelwell" class="git-link"> | |
| <button>GitHub</button> | |
| </a> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions