C16 - Cedar - Afina Walton #1

afinawalton · 2022-04-16T19:43:20Z

No description provided.

kyra-patton

⚠️ While you did implement a queue and stack, the instructions request that you specifically use a circular buffer to implement your queue and a linked list to implement your stack. Apologies if the instructions didn't make this clear.

Let me know what questions you have.

🔴

kyra-patton · 2022-04-28T04:31:22Z

lib/problems.js

@@ -0,0 +1,55 @@
+function balanced(string) {


💫🌸 Impressive! You didn't need to implement this, but good work. I apologize for the confusion!

kyra-patton · 2022-04-28T04:32:34Z

lib/queue.js

@@ -1,27 +1,33 @@
 class Queue {
    constructor() {


👀 While your implementation does work and utilize Javascript arrays effectively, the readme asks you to implement a queue using a circular buffer.

kyra-patton · 2022-04-28T04:33:54Z

lib/stack.js

@@ -1,19 +1,20 @@
 class Stack {


👀 While your implementation does work and utilize Javascript arrays effectively, unfortunately the readme requested you implement stacks using the included LinkedList class.

afinawalton · 2022-04-28T14:27:38Z

⚠️ While you did implement a queue and stack, the instructions request that you specifically use a circular buffer to implement your queue and a linked list to implement your stack. Apologies if the instructions didn't make this clear.

Let me know what questions you have.

🔴

@kp483 Hello! The README in the JavaScript version of this project includes a link with "See the Ruby version for details." that I honestly did not notice at all. So I didn't realize the project required a specific implementation.

In the future, is it possible to have these details added directly into the JavaScript README (rather than linked)?

I will re-do this project as soon as I can. Thank you.

kyra-patton · 2022-04-28T15:05:37Z

⚠️ While you did implement a queue and stack, the instructions request that you specifically use a circular buffer to implement your queue and a linked list to implement your stack. Apologies if the instructions didn't make this clear.
Let me know what questions you have.
🔴

@kp483 Hello! The README in the JavaScript version of this project includes a link with "See the Ruby version for details." that I honestly did not notice at all. So I didn't realize the project required a specific implementation.

In the future, is it possible to have these details added directly into the JavaScript README (rather than linked)?

I will re-do this project as soon as I can. Thank you.

Hi Afina, I agree the readme should be directly in the JavaScript version and have added it to our list of curriculum updates to implement. Additionally, I will be screening all future CS Fun projects to look out for this issue and be making changes as necessary. I apologize again that the JavaScript version was misleading and understand if you feel frustrated.

Take your time resubmitting; I'll look out for it and prioritize getting feedback to you quickly when you do.

kyra-patton

💪🏼 Nice changes to the Stack implementation!

kyra-patton · 2022-04-28T17:53:52Z

lib/stack.js

@@ -1,19 +1,20 @@
 class Stack {


kyra-patton · 2022-04-28T18:07:06Z

lib/stack.js

    }

    isEmpty() {
-        if (!this.store.length) return true;
-        return false;
+        return this.store.isEmpty();
    }

    toString() {


👀 You might consider LinkedList's toString method instead!

kyra-patton · 2022-04-28T18:07:13Z

lib/stack.js

+        const toRemove = this.store.getLast();
+        this.store.delete(toRemove);
+
+        return toRemove;
    }

    isEmpty() {


kyra-patton · 2022-04-28T18:07:21Z

lib/stack.js

    }

    push(element) {
-        this.store.push(element);
+        this.store.addLast(element);
        return;
    }

    pop() {


kyra-patton

🤠 Nice job Afina! Thanks for completing the project using a circular buffer and linked list respectively. I left a few comments on your new Queue implementation. Let me know what questions you have.

🟢

kyra-patton · 2022-05-04T02:04:04Z

lib/queue.js

-        throw new Error("This method has not been implemented!");
+        this.store = new Array(20);
+        // front and rear are index refs
+        this.#front = this.#rear = 0;


✨ Curious as to why you chose to set the front and rear fields as private

kyra-patton · 2022-05-04T05:06:26Z

lib/queue.js

    constructor() {
-        // this.store = ...
-        throw new Error("This method has not been implemented!");
+        this.store = new Array(20);


👀 When implementing a circular buffer, it's often helpful to have a capacity field to enable users to set the size of the buffer (you'd want to set capacity as a parameter which can to default to 20)

Suggested change

this.store = new Array(20);

this.capacity = capacity

this.store = new Array(capacity);

kyra-patton · 2022-05-04T05:10:48Z

lib/queue.js

+        else if (this.isEmpty()) {
+            this.store[this.#front] = element;
+        } else {
+            this.#rear += 1;


👀 Make sure you're handling the case where rear wraps around!

Suggested change

this.#rear += 1;

this.#rear = (this.#rear + 1) % this.capacity;

kyra-patton · 2022-05-04T05:11:21Z

lib/queue.js

+        ) {
+            throw 'QueueFullException'
+        }
+        else if (this.isEmpty()) {


✨ Nice use of your other methods!

kyra-patton · 2022-05-04T05:13:34Z

lib/queue.js

+        this.store[this.#front] = null;
+
+        if (this.#front === this.#rear) {
+            this.#front = this.#rear = -1;


In your constructor, you initialize front and rear to zero. Make sure you stay consistent on this

Suggested change

this.#front = this.#rear = -1;

this.#front = this.#rear = 0;

kyra-patton · 2022-05-04T05:14:48Z

lib/queue.js

+            this.#front += 1
+        }
+
+        return data;
    }

    front() {


kyra-patton · 2022-05-04T05:14:57Z

lib/queue.js

    }

    front() {
-        throw new Error("This method has not been implemented!");
+        return this.store[this.#front];
    }

    size() {


kyra-patton · 2022-05-04T05:15:03Z

lib/queue.js

    }

    size() {
-        throw new Error("This method has not been implemented!");
+        return this.store.length;
    }

    isEmpty() {


afinawalton added 4 commits April 16, 2022 11:27

Pass queue tests

2153c18

Add jest and make it verbose

0cc731c

Pass all stack tests

c6d4d3d

Create problems.js and pass problems tests

cbcc48f

kyra-patton reviewed Apr 28, 2022

View reviewed changes

Implements stack as a LinkedList

00fed8d

kyra-patton reviewed Apr 28, 2022

View reviewed changes

afinawalton added 2 commits May 1, 2022 10:52

Implement circular buffer

0d77dac

Get front without removing it

bdee8ce

kyra-patton reviewed May 4, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

C16 - Cedar - Afina Walton #1

C16 - Cedar - Afina Walton #1

afinawalton commented Apr 16, 2022

kyra-patton left a comment

kyra-patton Apr 28, 2022

kyra-patton Apr 28, 2022

kyra-patton Apr 28, 2022

kyra-patton Apr 28, 2022

afinawalton commented Apr 28, 2022 •

edited

Loading

kyra-patton commented Apr 28, 2022

kyra-patton left a comment

kyra-patton Apr 28, 2022

kyra-patton Apr 28, 2022

kyra-patton Apr 28, 2022

kyra-patton Apr 28, 2022

kyra-patton left a comment

kyra-patton May 4, 2022

kyra-patton May 4, 2022

kyra-patton May 4, 2022

kyra-patton May 4, 2022

kyra-patton May 4, 2022

kyra-patton May 4, 2022

kyra-patton May 4, 2022

kyra-patton May 4, 2022

	this.store = new Array(20);
	this.capacity = capacity
	this.store = new Array(capacity);

	this.#rear += 1;
	this.#rear = (this.#rear + 1) % this.capacity;

C16 - Cedar - Afina Walton #1

Are you sure you want to change the base?

C16 - Cedar - Afina Walton #1

Conversation

afinawalton commented Apr 16, 2022

kyra-patton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afinawalton commented Apr 28, 2022 • edited Loading

kyra-patton commented Apr 28, 2022

kyra-patton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kyra-patton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

afinawalton commented Apr 28, 2022 •

edited

Loading