Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C16 - Cedar - Afina Walton #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

C16 - Cedar - Afina Walton #1

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2153c18
Pass queue tests
afinawalton Apr 16, 2022
0cc731c
Add jest and make it verbose
afinawalton Apr 16, 2022
c6d4d3d
Pass all stack tests
afinawalton Apr 16, 2022
cbcc48f
Create problems.js and pass problems tests
afinawalton Apr 16, 2022
00fed8d
Implements stack as a LinkedList
afinawalton Apr 28, 2022
0d77dac
Implement circular buffer
afinawalton May 1, 2022
bdee8ce
Get front without removing it
afinawalton May 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions lib/stack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
const LinkedList = require("./linked-list");

class Stack {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 While your implementation does work and utilize Javascript arrays effectively, unfortunately the readme requested you implement stacks using the included LinkedList class.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

constructor() {
this.store = []
this.store = new LinkedList();
}

push(element) {
this.store.push(element);
this.store.addLast(element);
return;
}

pop() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

return this.store.pop();
const toRemove = this.store.getLast();
this.store.delete(toRemove);

return toRemove;
}

isEmpty() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

if (!this.store.length) return true;
return false;
return this.store.isEmpty();
}

toString() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 You might consider LinkedList's toString method instead!

Expand Down