All tests pass #32
Open
All tests pass #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyra-patton
reviewed
Jun 14, 2022
| pass | ||
| return True if self.size == 0 else False | ||
|
|
||
| def full(self): |
Comment on lines
+32
to
+36
| if self.full(): | ||
| buffer_increase = int(self.buffer_size * 0.5) | ||
| self.store = self.store[:self.rear] + [None] * buffer_increase + self.store[self.front:] | ||
| self.buffer_size += buffer_increase | ||
| self.front += buffer_increase |
There was a problem hiding this comment.
💫😎 Very nice, increasing the buffer size!
|
|
||
| self.store[self.rear] = element | ||
| self.rear = (self.rear + 1)% self.buffer_size | ||
| self.size += 1 | ||
|
|
||
| def dequeue(self): |
| element = self.store[self.front] | ||
| self.front = (self.front + 1)% self.buffer_size | ||
| self.size -= 1 | ||
| return element | ||
|
|
||
| def front(self): |
| pass | ||
| if self.empty(): | ||
| return None | ||
| return self.store[self.front] | ||
|
|
||
|
|
||
| def size(self): |
| return True if self.size == 0 else False | ||
|
|
||
| def full(self): | ||
| return self.size == self.buffer_size | ||
|
|
||
| def __str__(self): |
| @@ -12,7 +12,7 @@ def push(self, element): | |||
| """ Adds an element to the top of the Stack. | |||
| Returns None | |||
| """ | |||
| pass | |||
| self.store.add_first(element) | |||
| @@ -12,7 +12,7 @@ def push(self, element): | |||
| """ Adds an element to the top of the Stack. | |||
| Returns None | |||
| """ | |||
| pass | |||
| self.store.add_first(element) | |||
|
|
|||
| def pop(self): | |||
| pass | ||
| if self.empty(): | ||
| raise StackEmptyException("stack is empty") | ||
| return self.store.remove_first() | ||
|
|
||
| def empty(self): |
There was a problem hiding this comment.
✨ The LinkedList class also has an empty method you could take advantage of
|
|
||
| def empty(self): | ||
| """ Returns True if the Stack is empty | ||
| And False otherwise | ||
| """ | ||
| pass | ||
| return not self.store.get_first() | ||
|
|
||
| def __str__(self): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacks and Queues
Thanks for doing some brain yoga. You are now submitting this assignment!
Comprehension Questions
OPTIONAL JobSimulation