forked from AdaGold/video-store-consumer
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angela and Selam - &'s #21
Open
SelamawitA
wants to merge
49
commits into
Ada-C9:master
Choose a base branch
from
SelamawitA:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt styles a customers name and the amount of rentals. CustomerList makes call to Rails Api and populates a list of Customer components.
… MovieDB directly
…er's name tracked before a reservation.
…dding movie from DB to library - not working yet
… movie to post a rental to the rails api.
…ers. Future feature would be to implement a searching feature for movies/customer. Until then, this is more obvious to the user in how to use the site. Also, form will clear after a user submits a rental.
Merge branch 'master' of https://github.com/SelamawitA/video-store-consumer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video Store Consumer
Congratulations! You're submitting your assignment!
Comprehension Questions
For each person in your pair, describe something you learned from your partner during this project |
Selam - my partner did most of the research on dynamic routing and passed that knowledge on to me. With her work on the library and rental functionality she helped me understand the connection between the rails backend and front end as well.
Angela - Working with Selam was so great! She helped me stay calm and helped me get a better understanding of some CSS and making connection between components as well as getting the dates for rental checkouts.
What was one area of React you gained more clarity on during this assignment? | How to connect with a Rails backend!
Describe how you solved the problem of having lists of movies that look mostly the same but have different content | We put the movies into a flexbox and organized the more detailed content to be in a scrolling box.
Describe how you handled rentals with React | Each movie and customer has their own button who's necessary information is passed up as an object through their parent class to the App where the customer object is passed down as state to a Rental component. This part of the code really solidified that sibling communication is not a thing in React and a parent component is necessary to pass information.
Describe a DOM event your application handled | Our add a movie to the rental library button was an onClick event that triggered an axios post request.
Did you use any functional stateless components? What for? | We have a home page that has no state changes and returns the same thing consistently.
Did you use any container components? What for? | We created a container component to make a call to the API for a list of movies from the database and render movie components.
Do you have any recommendations on how we could improve this project for the next cohort? | I REALLY liked this project and very much appreciate getting to see how to connect front and back ends. Almost wish we could do this sooner if there was time.