-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and simplify build of static libraries. #3
base: master
Are you sure you want to change the base?
Conversation
HI @asarhaddon thanks for your contribution. You should have a look at this change: d49ff15 |
7389eb1
to
41cb918
Compare
This commit should hopefully fix the initial problem (some Debian architectures are missing a static archiver). A separate merge request (#4) fixes a probable typo. You are right that the remaining idea is similar to d49ff15.
|
41cb918
to
0f68f97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, due to a veritable zoo of architectures that AdaCore has to support, this patch is problematic for us as is. May I suggest that you just add specific triplets you would like to exclude, but leave the generic regexes intact?
This covers both native and cross builds, as /usr/bin/TARGET-ar exists in both cases.
0f68f97
to
49a70ab
Compare
gprconfig was generating no Archive_Builder attribute for
mips-linux-gnu, powerpc64le-linux-gnu and many other architectures,
because the regular expressions defining specific architectures and
the fallback were not covering all cases. Ensure that all cases are
covered by the fallback stanza.
Replace many handwritten copies with variable substitutions.
Merge i686-pc-mingw32 and x86_64-pc-mingw32 as already done for other
architectures with aliases.
Merge native x86 into the default stanza.
This merge request was
AdaCore/gprbuild#67 before the split to gprconfig-kb.
This merge request is causing, for at least the third time, a non-trivial merge conflict.
A recent conflict (d9e1487) introduces an error (unless "-ranlib" is a valid command). The change in this request would most probably have prevented such an error.