[trello.com/c/jKqpxiCa] update for paragraph 8 and 13 in the card #865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lainaaa
approved these changes
May 21, 2025
| return | ||
| } | ||
|
|
||
| guard let firstUnreadId = viewModel.unreadMessagesIds?.first, |
There was a problem hiding this comment.
you could combine this with previous checking
| let visibleBounds = messagesCollectionView.bounds | ||
| let restrictedVisibleRect = visibleBounds.insetBy(dx: 0, dy: 100) | ||
|
|
||
| let visibleSections: Set<Int> = Set( |
There was a problem hiding this comment.
let visibleSections: Set<Int> = Set(
messagesCollectionView.indexPathsForVisibleItems.compactMap {
guard let frame = messagesCollectionView.layoutAttributesForItem(at: $0)?.frame,
restrictedVisibleRect.intersects(frame) else { return nil }
return $0.section
}
)
| @@ -1395,4 +1445,11 @@ private let messagePadding: CGFloat = 12 | |||
| private let filesToolbarViewHeight: CGFloat = 140 | |||
| private let targetYOffset: CGFloat = 20 | |||
| private let scrollButtonHeight: CGFloat = 30 | |||
| private let hiddenScrollViewPartHeight: CGFloat = 94 | |||
| //not a real height just for reading messages | |||
| private var hiddenScrollViewPartHeight: CGFloat { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check by commits