feat: placeholder in a new chat #765
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
skranee
changed the title
|
Deployed to https://msg-adamant-pr-765.surge.sh 🚀 |
|
It seems like the only thing left to do is to fix this weird bug with scrollbar, for now I have absolutely no idea why this happens and how to fix this little thing even though I've spent hours on trying to discover that. If you have any suggestions - I'd be highly greatful for them because I consider that bug annoying and worth of being fixed unless Alexey (@adamant-al) tells the opposite and desides that this bug is not a priority right now. |
|
@skranee |
A draft for now |
|
Regarding the bug, it could be separated as another task. |
|
@S-FrontendDev @bludnic |
| @@ -10,13 +10,16 @@ | |||
| <v-progress-circular | |||
| v-show="loading" | |||
| indeterminate | |||
| color="primary" | |||
| size="24" | |||
| :class="[classes.spinner, !messages.length ? `${classes.spinner}_no-messages` : '']" | |||
There was a problem hiding this comment.
why is it not object?
:class="{ [classes.spinner]: true, [${classes.spinner}_no-messages`]: !messages.length }"
There was a problem hiding this comment.
Just another way of setting class names, I think it's more a matter of taste
| const classes = [ | ||
| `${className}__form`, | ||
| { | ||
| [`${className}__form--is-active`]: !!message.value | ||
| } | ||
| ] |
There was a problem hiding this comment.
it's not right way to use classes
There was a problem hiding this comment.
why not? they're used as an array, seems fine to me
<div :class="classes">
There was a problem hiding this comment.
I'd agree if it they were used separately like :class="classes.form" or somethings like that
| set: setEmojiPickerOpen | ||
| }) | ||
| const placeholder = computed(() => props.label ?? t('chats.type_a_message')) | ||
| const isDesktopDevice = computed(() => !isMobile()) |
There was a problem hiding this comment.
i think it's not computedable
Lmk if you have any suggestions guys
https://trello.com/c/ukeJHNFi/