reset trusted domains on extension settings reset

Author: slavaleleka

Extension/src/background/api/document-block.ts

@@ -89,4 +89,11 @@ export class DocumentBlockApi {
 
         DocumentBlockApi.storeTrustedDomain(hostname);
     }
+
+    /**
+     * Resets trusted domains to empty array.
+     */
+    public static async reset(): Promise<void> {
+        await trustedDomainsStorage.setData([]);
+    }
 }

Extension/src/background/api/settings/main.ts

@@ -73,6 +73,7 @@ import {
     GPC_SCRIPT_OUTPUT,
     HIDE_DOCUMENT_REFERRER_OUTPUT,
 } from '../../../../../constants';
+import { DocumentBlockApi } from '../document-block';
 import { filteringLogApi } from '../filtering-log';
 import { network } from '../network';
 import { CommonFilterUtils } from '../../../common/common-filter-utils';
@@ -216,6 +217,9 @@ export class SettingsApi {
         // On import should enable only groups from imported file.
         await CommonFilterApi.initDefaultFilters(enableUntouchedGroups);
 
+        // reset trusted domains list
+        await DocumentBlockApi.reset();
+
         // reset list of consented filter ids on reset settings
         await annoyancesConsent.reset();
     }

tests/src/background/api/document-block.test.ts

@@ -80,4 +80,31 @@ describe('document block api', () => {
             }),
         ).toBe(true);
     });
+
+    it('Resets trusted domains', async () => {
+        const url = 'https://example.org/test';
+
+        await DocumentBlockApi.init();
+
+        vi.spyOn(Date, 'now').mockImplementation(() => 0);
+
+        await DocumentBlockApi.setTrustedDomain(url);
+
+        expect(
+            browser.storage.local.set.calledWith({
+                [TRUSTED_DOCUMENTS_CACHE_KEY]: JSON.stringify([{
+                    domain: 'example.org',
+                    expires: DocumentBlockApi.TRUSTED_TTL_MS,
+                }]),
+            }),
+        ).toBe(true);
+
+        await DocumentBlockApi.reset();
+
+        expect(
+            browser.storage.local.set.calledWith({
+                [TRUSTED_DOCUMENTS_CACHE_KEY]: JSON.stringify([]),
+            }),
+        ).toBe(true);
+    });
 });

tests/src/background/api/settings.test.ts

@@ -16,6 +16,7 @@ import {
     HIDE_DOCUMENT_REFERRER_OUTPUT,
 } from '../../../../constants';
 import {
+    DocumentBlockApi,
     Network,
     SettingsApi,
     type SettingsData,
@@ -222,10 +223,16 @@ describe('Settings Api', () => {
 
         it('Reset default settings', async () => {
             await SettingsApi.setSetting(SettingOption.AllowlistEnabled, false);
+            expect(SettingsApi.getSetting(SettingOption.AllowlistEnabled)).toBe(false);
+
+            // test trusted domains list as well since it is temporary and not stores as a part of settings
+            await DocumentBlockApi.setTrustedDomain('https://example.com/test');
+            expect(await DocumentBlockApi.getTrustedDomains()).toStrictEqual(['example.com']);
 
             await SettingsApi.reset(true);
 
             expect(SettingsApi.getSetting(SettingOption.AllowlistEnabled)).toBe(true);
+            expect(await DocumentBlockApi.getTrustedDomains()).toStrictEqual([]);
         }, EXTENDED_TIMEOUT_MS);
     });
 });