Reviews marked: Reviewed by is for whole team and Reviewed for: student code for particular student

[apoorvachikara]

Backend:

• NA

Frontend:

• Url paths should be short and descriptive(you are using camel case in some), check this: https://www.mtrmarketing.com/blog/url-naming-best-practices
 - Job feed is empty when we first time load it, there is no loading icon to show we are loading it
• The project components should be more organised for ex: apply now components should be under apply now
  • ApplyNow
    • ApplyNow.jsx
    • ApplyNowSubmit.jsx
• How to create project structure? check this: https://profy.dev/article/react-folder-structure
• use CSS nesting, check this link: https://www.w3.org/TR/css-nesting-1/
• No documentation or comments on any function or code that is complex
• put loaders or anything that tells user that the web app is loading the data
• revisit hooks:

Git Review:
 - commit messages should be descriptive
- PR description should be broad and include changes or any breaking changes (this is important whenever you make any big change in architecture)
- PR should be raised for every new feature addeD
- branch name should be always based on feature name or the JIRA ticket (dependent on CI/CD workflows)

Adil - Main Page - fw17_0992

• Use loops when you want to render same components/nodes, but with dynamic data
• explain more clearly about the work you did, the delivery can be more desciptive
• remove redundant code whenever necessary
• focus how we can reuse exisiting code with dynamic configurations

Bhagesh - Login/auth - fw16_443

• create env file for such secret that should be picked up based on your build(dev, staging or prod)
• Use loops when you want to render same components/nodes, but with dynamic data
• use CSS nesting, check this link: https://www.w3.org/TR/css-nesting-1/
• follow naming convention or a single line comment what is getting updated

Akhil - Apply job flow - fw17_1110

• No notification when job is applied
• never use async/await with then/catch, check this: https://stackoverflow.com/questions/54495711/async-await-vs-then-which-is-the-best-for-performance
• How to create project structure? check this: https://profy.dev/article/react-folder-structure
• Use loops when you want to render same components/nodes, but with dynamic data
• Try to create one component if we have similar functionalities

Ashish - Company Reviews - fw14_265

• avoid in-line css as you might end up writing more and will be difficult to manage on view
• code indentation for better readability

Balu - Salary guide - fw13_096

• You need to clearly talk about the task with confidence what, why and how you did it
• Use URLs from config file based on which env you created the web app for, check this: https://trekinbami.medium.com/using-environment-variables-in-react-6b0a99d83cf5
• meaningful variable name helps reading code and debugging it easily.
• use constant or json files to get static content in your view to manage it
• Use css nesting, check this link: https://www.w3.org/TR/css-nesting-1/
• code indentation for better readability
• How to use SVG in the view? Check this: https://www.sanity.io/guides/import-svg-files-in-react

Note: comment if you don't understand anything.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
indeed	❌ Failed (Inspect)		Sep 19, 2022 at 2:42PM (UTC)

[apoorvachikara]

The deployment should start only when the branch is successfully merged. You can use Sonarqube to do the code analysis and based on it merge it.