Skip to content

payment-tags #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 6, 2025
Merged

payment-tags #130

merged 7 commits into from
Jun 6, 2025

Conversation

nimithajalal
Copy link
Collaborator

@nimithajalal nimithajalal commented May 28, 2025

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nimithajalal nimithajalal added documentation Improvements or additions to documentation Do not merge Do no merge—Review in progress labels May 28, 2025
Copy link
Collaborator

@undavide undavide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@nimithajalal I see a link error in the validation test, try running yarn test:links :-)
image

@nimithajalal nimithajalal removed the Do not merge Do no merge—Review in progress label Jun 6, 2025
@nimithajalal nimithajalal merged commit 903df62 into main Jun 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants